public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] [PATCH v3] netloop: updates for NetLoop
Date: Tue, 28 Apr 2009 08:21:23 +0200	[thread overview]
Message-ID: <49F6A063.4030702@denx.de> (raw)
In-Reply-To: <49F6ABA5.1040901@gmail.com>

Hello Ben,

Ben Warren wrote:
> Heiko Schocher wrote:
>> Fix some issues introduced from commit:
>> 2f70c49e5b9813635ad73666aa30f304c7fdeda9
>> suggested by Mike Frysinger.
>>
>> - added some comment for the env_id variable in common_cmd_nvedit.c
>> - moved some variables in fn scope instead of file scope
>> - NetInitLoop now static void
>>
>> Signed-off-by: Heiko Schocher <hs@denx.de>
>>   
> Please put your real e-mail address here.

Ups, sorry, send a new one ...

> Also, can you please verify that everything still works fine when this
> patch is applied to net/next?  It has Michael Zaidman's "NetLoop
> initialization bug" fix applied.

This patch from Michael is also in actual u-boot.git, so I tested
my patch with actual u-boot.git, on a mpc8xx, mpc82xx and on a mpc83xx
based board, without showing the bug which Michael's patch fixed, so
it seems to work fine.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2009-04-28  6:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-02-25 12:40 [U-Boot] [PATCH] netloop: updates for NetLoop Heiko Schocher
2009-02-25 17:01 ` Mike Frysinger
2009-02-26  7:16   ` [U-Boot] [PATCH v2] " Heiko Schocher
2009-02-26  8:47     ` Mike Frysinger
2009-04-03 21:57     ` Wolfgang Denk
2009-04-03 23:28       ` Michael Zaidman
2009-04-24 19:45       ` Wolfgang Denk
2009-04-24 23:41         ` Ben Warren
2009-04-27 22:09     ` Wolfgang Denk
2009-04-28  5:41       ` [U-Boot] [PATCH] [PATCH v3] " Heiko Schocher
2009-04-28  7:09         ` Ben Warren
2009-04-28  6:21           ` Heiko Schocher [this message]
2009-04-28  6:36           ` [U-Boot] [PATCH v4] " Heiko Schocher
2009-04-28 17:22             ` Ben Warren
2009-05-15 19:18               ` Wolfgang Denk
2009-05-15 19:18             ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49F6A063.4030702@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox