From mboxrd@z Thu Jan  1 00:00:00 1970
From: Tom <Tom.Rix@windriver.com>
Date: Wed, 29 Apr 2009 22:41:24 -0500
Subject: [U-Boot] [PATCH 5/5] ZOOM2 Add led support.
In-Reply-To: <20090429205642.GD522@game.jcrosoft.org>
References: <1240933314-12769-1-git-send-email-Tom.Rix@windriver.com>
	<1240933314-12769-2-git-send-email-Tom.Rix@windriver.com>
	<1240933314-12769-3-git-send-email-Tom.Rix@windriver.com>
	<1240933314-12769-4-git-send-email-Tom.Rix@windriver.com>
	<1240933314-12769-5-git-send-email-Tom.Rix@windriver.com>
	<20090429205642.GD522@game.jcrosoft.org>
Message-ID: <49F91DE4.808@windriver.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Jean-Christophe PLAGNIOL-VILLARD wrote:

<snip>
>> +void red_LED_off (void)
>> +{
>> +	/* red */
>> +	if (!omap_request_gpio(173)) {
>> +		omap_set_gpio_direction(173, 0);
>> +		omap_set_gpio_dataout(173, 0);
>> +	}
>>     
> it will be better to do this at the init of the led
>
>   
There is no init function.
I did not have one because the init is trivial and the led's are used 
for early board debugging.
>> +	saved_state[STATUS_LED_RED] = STATUS_LED_OFF;
>> +}
>> +
>> +void blue_LED_off (void)
>> +
>>     
<snip>
>>  #include <asm/arch/mem.h>
>>  #include <asm/arch/mux.h>
>> @@ -78,7 +81,6 @@ int board_init (void)
>>  #if defined(CONFIG_STATUS_LED) && defined(STATUS_LED_BOOT)
>>  	status_led_set (STATUS_LED_BOOT, STATUS_LED_ON);
>>  #endif
>> -
>>     
> please do not do clean up at the same time
>
>   
Please explain.

Tom