From mboxrd@z Thu Jan 1 00:00:00 1970 From: Richard Retanubun Date: Fri, 01 May 2009 17:29:22 -0400 Subject: [U-Boot] Question about M29W128G CFI QRY bug In-Reply-To: <200904151726.19326.sr@denx.de> References: <49DE84CE.4030103@RuggedCom.com> <49E5E27F.1080407@RuggedCom.com> <200904151630.02072.sr@denx.de> <200904151726.19326.sr@denx.de> Message-ID: <49FB69B2.5040405@RuggedCom.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stefan Roese wrote: > On Wednesday 15 April 2009, Stefan Roese wrote: >>>> I don't like both versions. We should implement something which doesn't >>>> change the current behavior probably needed on some other boards. So >>>> how about something like this: >>> I took your proposal and tried to implement it, hit a snag with >>> flash_write_cmd currently being a private function of cfi-flash.c >>> so, here is my 'counter-offer' pasted at the end of the message. >> Thanks. Looks good. I'll take it and prepare a proper patch. > > Hmm. After looking a bit closer this doesn't seem to be this easy. I would > like to add this function prototype to include/flash.h where other defines > and function prototypes are collected right now. But this breaks some other > boards implementing "their own" flash driver in their board directories, like > AP1000, cpci5200, G2000, ppmc8260 and sbc405 (maintainers added to CC). > > All those boards should be able to use the common CFI flash driver. I would > really like to see those boards converted to this driver. It should be pretty > easy. So maintainers from the boards mentioned above, if you need any help > with this just let me know. > Hi Stefan, Would I be foolish to hope that this can be merged in for 2009.06? :) Thanks - Richard