public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@pobox.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] MIPS: Implement ethernet halt for au1x00
Date: Sun, 03 May 2009 10:20:53 +0900	[thread overview]
Message-ID: <49FCF175.9050501@pobox.com> (raw)
In-Reply-To: <49F1CB18.9070608@corelatus.se>

Thomas Lange wrote:
> Implement ethernet halt() by putting MAC0 in reset.
> If we do not do this, we will get memory corruption
> when ethernet frames are received during early OS boot.
> 
> Signed-off-by: Thomas Lange <thomas@corelatus.se>
> ---
>  cpu/mips/au1x00_eth.c |    4 ++++
>  1 files changed, 4 insertions(+), 0 deletions(-)
> 
> diff --git a/cpu/mips/au1x00_eth.c b/cpu/mips/au1x00_eth.c
> index 6272a3a..5074997 100644
> --- a/cpu/mips/au1x00_eth.c
> +++ b/cpu/mips/au1x00_eth.c
> @@ -276,6 +276,10 @@ static int au1x00_init(struct eth_device* dev, bd_t * bd){
>  }
> 
>  static void au1x00_halt(struct eth_device* dev){
> +	volatile u32 *macen = (volatile u32*)MAC0_ENABLE;
> +
> +	/* Put MAC0 in reset */
> +	*macen = 0;
>  }
> 
>  int au1x00_enet_initialize(bd_t *bis){

Acked-by: Shinya Kuribayashi <skuribay@pobox.com>


Wolfgang-san,

could you please pick up this patch directly?  Thanks,

  Shinya

      reply	other threads:[~2009-05-03  1:20 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-04-24 14:22 [U-Boot] [PATCH] MIPS: Implement ethernet halt for au1x00 Thomas Lange
2009-05-03  1:20 ` Shinya Kuribayashi [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=49FCF175.9050501@pobox.com \
    --to=skuribay@pobox.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox