[PATCH 05/14] spi: spi-mem: Add debug message for spi-mem ops

Bin Meng
2021-02-01T05:06:13Z

On Mon, Feb 1, 2021 at 8:36 AM Sean Anderson <seanga2@gmail.com> wrote:
>
> This prints some basic metadata about the SPI memory op. This information
> may be used to debug SPI drivers (e.g. determining the expected SPI mode).
> It is also helpful for verifying that the data on the wire matches the data
> intended to be transmitted (e.g. with a logic analyzer). The opcode is
> printed with a format of %02Xh to match the notation commonly used in flash
> datasheets.
>
> Signed-off-by: Sean Anderson <seanga2@gmail.com>
> ---
>
> drivers/spi/spi-mem.c | 6 ++++++
> 1 file changed, 6 insertions(+)
>
> diff --git a/drivers/spi/spi-mem.c b/drivers/spi/spi-mem.c
> index c095ae9505..eb83c11910 100644
> --- a/drivers/spi/spi-mem.c
> +++ b/drivers/spi/spi-mem.c
> @@ -220,6 +220,12 @@ int spi_mem_exec_op(struct spi_slave *slave, const struct spi_mem_op *op)
> int ret;
> int i;
>
> + dev_dbg(slave->dev, "exec %02Xh %u-%u-%u addr=%llx wait=%u len=%u\n",

dummy cycles=%u, data len=%u to be clearer?

> + op->cmd.opcode, op->cmd.buswidth, op->addr.buswidth,
> + op->data.buswidth, op->addr.val,
> + op->dummy.buswidth ? op->dummy.nbytes * 8 / op->dummy.buswidth : 0,
> + op->data.nbytes);
> +
> if (!spi_mem_supports_op(slave, op))
> return -ENOTSUPP;
>
> --

Otherwise LGTM
Reviewed-by: Bin Meng <bmeng.cn@gmail.com>