Re: [PATCH v2 1/2] disk/part.c: ensure strings in struct disk_partition are valid after successful get_info

[Quentin Schulz <quentin.schulz@cherry.de>]

Hi Rasmus,

On 10/20/25 2:10 PM, Rasmus Villemoes wrote:
> Not all ->get_info implementations necessarily populate all the string
> members of struct disk_partition.
> 
> Currently, only part_get_info_by_type() (and thereby part_get_info)
> ensure that the uuid strings are initialized; part_get_info_by_type()
> and part_get_info_by_uuid() do not. In fact, the latter could lead to
> a false positive match - if the ->get_info backend does not populate
> info->uuid, stale contents in info could cause the strncasecmp() to
> succeed.
> 
> None of the functions currently ensure that the ->name and ->type
> strings are initialized.
> 
> Instead of forcing all callers of any of these functions to
> pre-initialize info, or all implementations of the ->get_info method
> to ensure there are valid C strings in all four fields, create a small
> helper function and factor all invocations of ->get_info through that.
> 

Considering we only have code calling get_info() function of the part 
driver in the two files changed in this commit, but there's nothing 
forbidding users to call it from their driver or board files, but I 
guess this is good enough and we can worry about non-existing users later?

> This also consolidates the -ENOSYS check and standardizes on using
> log_debug() for reporting absence, instead of the current mix of
> PRINTF and log_debug(). It does mean we have to special-case -ENOSYS
> in the error cases inside the loops in the _by_uuid() and _by_name()
> functions, but it's still a net win in #LOC.
> 

Acked-by: Quentin Schulz <quentin.schulz@cherry.de>

Thanks!
Quentin