From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2] mtd: nand: new base driver for memory mapped nand devices
Date: Wed, 06 May 2009 13:19:07 -0500 [thread overview]
Message-ID: <4A01D49B.1010603@freescale.com> (raw)
In-Reply-To: <200905061404.20032.vapier@gentoo.org>
Mike Frysinger wrote:
>>> +/* #define CONFIG_NAND_PLAT */
>> Why is this commented out?
>
> because it's a driver for an optional add-on card that people usually dont
> have, let alone plugged in
OK, was hoping there would be at least one config that selects it so it
gets compilation exposure.
>>> +#define NAND_PLAT_DEV_READY(chip) ((*pPORTFIO & BFIN_NAND_READY) ?
>>> 1 : 0)
>> Why not just (*pPORTFIO & BFIN_NAND_READY)?
>
> i thought the nand/mtd layers expect 1/0 only ? if the higher layers dont
> care, then there's no reason.
A quick grep doesn't show any non-boolean uses.
-Scott
next prev parent reply other threads:[~2009-05-06 18:19 UTC|newest]
Thread overview: 24+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-04-12 1:26 [U-Boot] [PATCH] mtd: nand: new base driver for memory mapped nand devices Mike Frysinger
2009-04-13 15:59 ` Scott Wood
2009-04-13 21:18 ` Mike Frysinger
2009-04-13 21:42 ` Scott Wood
2009-04-13 22:09 ` Mike Frysinger
2009-04-13 23:02 ` Scott Wood
2009-04-13 23:47 ` Mike Frysinger
2009-05-06 13:05 ` [U-Boot] [PATCH v2] " Mike Frysinger
2009-05-06 17:35 ` Scott Wood
2009-05-06 18:04 ` Mike Frysinger
2009-05-06 18:19 ` Scott Wood [this message]
2009-05-06 19:14 ` Mike Frysinger
2009-05-06 19:38 ` [U-Boot] [PATCH v3] " Mike Frysinger
2009-05-06 19:49 ` Scott Wood
2009-05-06 20:10 ` Mike Frysinger
2009-05-06 20:53 ` Wolfgang Denk
2009-05-06 20:51 ` [U-Boot] [PATCH v2] " Wolfgang Denk
2009-05-06 23:28 ` Mike Frysinger
2009-05-07 0:28 ` [U-Boot] [PATCH v4] " Mike Frysinger
2009-05-11 19:14 ` Scott Wood
2009-05-13 23:45 ` [U-Boot] [PATCH v5] " Mike Frysinger
2009-05-19 21:55 ` Scott Wood
2009-05-26 2:42 ` [U-Boot] [PATCH v6] " Mike Frysinger
2009-05-29 19:52 ` Scott Wood
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A01D49B.1010603@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox