From mboxrd@z Thu Jan  1 00:00:00 1970
From: Scott Wood <scottwood@freescale.com>
Date: Wed, 06 May 2009 13:19:07 -0500
Subject: [U-Boot] [PATCH v2] mtd: nand: new base driver for memory
 mapped nand devices
In-Reply-To: <200905061404.20032.vapier@gentoo.org>
References: <1239499602-19356-1-git-send-email-vapier@gentoo.org>
	<1241615121-15945-1-git-send-email-vapier@gentoo.org>
	<20090506173529.GA26403@ld0162-tx32.am.freescale.net>
	<200905061404.20032.vapier@gentoo.org>
Message-ID: <4A01D49B.1010603@freescale.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Mike Frysinger wrote:
>>> +/* #define CONFIG_NAND_PLAT */
>> Why is this commented out?
> 
> because it's a driver for an optional add-on card that people usually dont 
> have, let alone plugged in

OK, was hoping there would be at least one config that selects it so it 
gets compilation exposure.

>>> +#define NAND_PLAT_DEV_READY(chip)      ((*pPORTFIO & BFIN_NAND_READY) ?
>>> 1 : 0)
>> Why not just (*pPORTFIO & BFIN_NAND_READY)?
> 
> i thought the nand/mtd layers expect 1/0 only ?  if the higher layers dont 
> care, then there's no reason.

A quick grep doesn't show any non-boolean uses.

-Scott