[U-Boot] [PATCH] Canyonlands SATA harddisk driver

Wolfgang Denk
2009-05-07T07:38:00Z

Dear Kazuaki Ichinohe,

In message <4A027E44.5080100@fsi.co.jp> you wrote:
> Hello Denk, Stefan,
>
> > Could you please rebase your patch against the current top-of-tree mainline
> > repository and resumbmit?
>
> Thank you for the reply.
> I made the patch from the source obtained with git in 5/7.
> The confirmed patch is sent again.
> Please review this patch.
> ---

Please put comments BELOW the "---" line, not above. Only put the
commit message ABOVE the "---" line. And note that there is only ONE
"---" line in a patch.

> [patch]
> diff -uprN u-boot-0507/drivers/block/Makefile u-boot-sata/drivers/block/Makefile
> --- u-boot-0507/drivers/block/Makefile 2009-05-07 09:25:48.000000000 +0900
> +++ u-boot-sata/drivers/block/Makefile 2009-05-07 09:43:56.000000000 +0900
> @@ -35,6 +35,7 @@ COBJS-$(CONFIG_SATA_SIL3114) += sata_sil
> COBJS-$(CONFIG_SCSI_AHCI) += ahci.o
> COBJS-$(CONFIG_SCSI_SYM53C8XX) += sym53c8xx.o
> COBJS-$(CONFIG_SYSTEMACE) += systemace.o
> +COBJS-$(CONFIG_SATA_DWC) += sata_dwc.o

Sorry, your patch is white-space corrupted:

patching file drivers/block/Makefile
Hunk #1 FAILED at 35.
1 out of 1 hunk FAILED -- saving rejects to file
drivers/block/Makefile.rej
patching file drivers/block/sata_dwc.c
patching file drivers/block/sata_dwc.h
patching file include/configs/canyonlands.h
Hunk #1 FAILED at 454.
patch: **** malformed patch at line 2718: Thanks.

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nearly everyone is in favor of going to heaven but too many are
hoping they'll live long enough to see an easing of the entrance
requirements. Never appeal to a man's "better nature." he might not
have one.