public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] OMAP3EVM: net_chip uses CS5 not CS6
Date: Thu, 07 May 2009 17:16:04 +0200	[thread overview]
Message-ID: <4A02FB34.2090907@googlemail.com> (raw)
In-Reply-To: <20090507083634.5ECB883420E8@gemini.denx.de>

Dear Wolfgang,

Wolfgang Denk wrote:
> Dear Matthias Ludwig,
> 
> In message <20090507071155.GA8961@ultratronik.de> you wrote:
>> This is not really a change. The cs configuration was correct, but not
>> the naming of it.
>>
>> OMAP34XX_GPMC_BASE (0x6e000000) + 0x150 = base address of configuration
>> registers for GPMC-CS5 not GPMC-CS6.
> 
> Can we please get rid of all this crap with register offsets and
> device accesses through pointers using base address plus offset?
> 
> Please provide proper C structs!

Would you like to have a look to the code snippet visible in Matthias' 
patch

http://lists.denx.de/pipermail/u-boot/2009-May/052157.html

?

It's my understanding that what's in code

writel(NET_GPMC_CONFIG1, &gpmc_cs5_base->config1);

is what you want? I.e. as I understand it, the code is correct (we use 
C structs), and the style Matthias used above you complain about was 
just for patch explanation (to make it easier understandable).

Sorry if I missed something, just correct then ;)

Best regards

Dirk

  reply	other threads:[~2009-05-07 15:16 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-06 13:00 [U-Boot] [PATCH] OMAP3EVM: net_chip uses CS5 not CS6 Matthias Ludwig
2009-05-06 14:55 ` Dirk Behme
2009-05-07  7:04   ` Pillai, Manikandan
2009-05-07  7:11     ` Matthias Ludwig
2009-05-07  7:15       ` Pillai, Manikandan
2009-05-07  8:36       ` Wolfgang Denk
2009-05-07 15:16         ` Dirk Behme [this message]
2009-05-07 18:58           ` Wolfgang Denk
2009-05-07 19:18             ` Scott Wood
2009-05-07 20:42               ` Wolfgang Denk
2009-05-07 20:56                 ` Scott Wood
2009-05-07 21:04                   ` Wolfgang Denk
2009-05-07 21:10                     ` Scott Wood
2009-05-08 12:28                       ` Detlev Zundel
2009-05-08 15:10                         ` Dirk Behme
2009-05-08  8:42             ` Matthias Ludwig
2009-05-08  9:00               ` Wolfgang Denk
2009-05-08 15:12               ` Dirk Behme
2009-05-07 20:57       ` Jean-Christophe PLAGNIOL-VILLARD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A02FB34.2090907@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox