From mboxrd@z Thu Jan  1 00:00:00 1970
From: Dirk Behme <dirk.behme@googlemail.com>
Date: Thu, 07 May 2009 17:16:04 +0200
Subject: [U-Boot] [PATCH] OMAP3EVM: net_chip uses CS5 not CS6
In-Reply-To: <20090507083634.5ECB883420E8@gemini.denx.de>
References: <1241614855-8087-1-git-send-email-mludwig@ultratronik.de>	<4A01A4CD.2060605@googlemail.com>	<19F8576C6E063C45BE387C64729E739404323ED93C@dbde02.ent.ti.com>	<20090507071155.GA8961@ultratronik.de>
	<20090507083634.5ECB883420E8@gemini.denx.de>
Message-ID: <4A02FB34.2090907@googlemail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Dear Wolfgang,

Wolfgang Denk wrote:
> Dear Matthias Ludwig,
> 
> In message <20090507071155.GA8961@ultratronik.de> you wrote:
>> This is not really a change. The cs configuration was correct, but not
>> the naming of it.
>>
>> OMAP34XX_GPMC_BASE (0x6e000000) + 0x150 = base address of configuration
>> registers for GPMC-CS5 not GPMC-CS6.
> 
> Can we please get rid of all this crap with register offsets and
> device accesses through pointers using base address plus offset?
> 
> Please provide proper C structs!

Would you like to have a look to the code snippet visible in Matthias' 
patch

http://lists.denx.de/pipermail/u-boot/2009-May/052157.html

?

It's my understanding that what's in code

writel(NET_GPMC_CONFIG1, &gpmc_cs5_base->config1);

is what you want? I.e. as I understand it, the code is correct (we use 
C structs), and the style Matthias used above you complain about was 
just for patch explanation (to make it easier understandable).

Sorry if I missed something, just correct then ;)

Best regards

Dirk