From mboxrd@z Thu Jan 1 00:00:00 1970 From: Daniel Gorsulowski Date: Fri, 08 May 2009 07:37:31 +0200 Subject: [U-Boot] [PATCH 1/1] at91: Add command to control up to 3 GPIO LEDs from the console In-Reply-To: <20090507073232.C075583420E8@gemini.denx.de> References: <1241619669338-git-send-email-Daniel.Gorsulowski@esd.eu> <20090506203728.9779B83420E8@gemini.denx.de> <4A02792B.8060102@esd.eu> <20090507073232.C075583420E8@gemini.denx.de> Message-ID: <4A03C51B.7050404@esd.eu> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Wolfgang Denk schrieb: > Dear Daniel Gorsulowski, > > In message <4A02792B.8060102@esd.eu> you wrote: >>> Ummm... common is for, well, for >>common<< stuff. If this code is >>> specific to AT91 only, it should not go into common. >>> >> IMHO this code is not specific to AT91 only. Well, other architectures does not >> support the CONFIG_CMD_LED yet, but they could be implemented later. > > This is not quite correct. Actually several boards already support > this, or very similar functions: > > board/amcc/taihu/taihu.c:static int do_led_ctl(cmd_tbl_t* cmd_tp, int flags, int argc, char *argv[]) > board/amcc/taishan/lcd.c:static int do_led_test_off(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) > board/amcc/taishan/lcd.c:static int do_led_test_on(cmd_tbl_t * cmdtp, int flag, int argc, char *argv[]) > board/cm5200/cmd_cm5200.c:int do_led(char *argv[]) > board/pcs440ep/pcs440ep.c:int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) > board/pn62/cmd_pn62.c:int do_led (cmd_tbl_t *cmdtp, int flag, int argc, char *argv[]) > board/tqc/tqm5200/cmd_stk52xx.c:int do_led(char *argv[]) > board/trab/trab_fkt.c:int do_led (char **); > board/trab/trab_fkt.c:int do_led (char **argv) > Can you tell me a better place for at91 specific code? I think lib_arm is not the proper place for it. I meant to place it in arm926ejs/at91, what do you mean? > ... > > Best regards, > > Wolfgang Denk > Best regards, Daniel Gorsulowski