public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 2/3] OMAP3: Rename interrupts.c to timer.c
Date: Fri, 08 May 2009 17:47:27 +0200	[thread overview]
Message-ID: <4A04540F.10507@googlemail.com> (raw)
In-Reply-To: <20090507204121.GC3302@game.jcrosoft.org>

Dear Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 17:41 Tue 05 May     , Dirk Behme wrote:
>> After removal of dublicated interrupt code, rename file to what it
>> really does now.
> I prefer to rename all files at the same time

Then, please don't complain that you have "to do everything on your 
own and nobody helps you" ;) I would prefer that changes are done by 
the board maintainers and not by the custodian, though.

> Btw please use git to show that you only rename the file without change

I'm not sure that this works for non-custodians. Custodians can do 
git-rename and then send a patch to the mailing list. When a custodian 
sends such a patch, it is mainly for review only, and not to be 
applied somewhere (because it is already in git).

This results then in something

cpu/sa1100/{interrupts.c => timer.c}             |    5 +-
rename cpu/arm925t/{interrupts.c => timer.c} (99%)

(from [1]). But this is only what normally 'diffstat' generates and 
what is totally ignored by 'patch' . I.e. in the part of the patch 
which is handled by 'patch' this info is totally missing. As far as I 
know 'patch' itself can't deal with file rename any other way than 
remove one file and create the other one with

--- u-boot-main.orig/cpu/arm_cortexa8/omap3/interrupts.c
+++ /dev/null

--- /dev/null
+++ u-boot-main/cpu/arm_cortexa8/omap3/timer.c

So it's my understanding that non-custodians have to send a patch 
which can be applied everywhere by everyone by 'patch' utility, i.e. 
the part 'patch' deals with contains all information necessary.

Do I miss anything?

Best regards

Dirk

[1] http://lists.denx.de/pipermail/u-boot/2009-May/051921.html

  reply	other threads:[~2009-05-08 15:47 UTC|newest]

Thread overview: 13+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-05 15:41 [U-Boot] [PATCH 0/3] OMAP3: Minor code clean up, no functional change Dirk Behme
2009-05-05 15:41 ` [U-Boot] [PATCH 1/3] OMAP3: Remove dublicated interrupt code Dirk Behme
2009-05-05 15:41   ` [U-Boot] [PATCH 2/3] OMAP3: Rename interrupts.c to timer.c Dirk Behme
2009-05-05 15:41     ` [U-Boot] [PATCH 3/3] OMAP3: Reorganize Makefile style Dirk Behme
2009-05-07 20:42       ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-08 15:30         ` Dirk Behme
2009-05-07 20:41     ` [U-Boot] [PATCH 2/3] OMAP3: Rename interrupts.c to timer.c Jean-Christophe PLAGNIOL-VILLARD
2009-05-08 15:47       ` Dirk Behme [this message]
2009-05-08 18:23         ` Scott Wood
2009-05-08 18:35           ` Dirk Behme
2009-05-08 18:41             ` Scott Wood
2009-05-11  6:58             ` Wolfgang Denk
2009-05-08 19:29         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A04540F.10507@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox