From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Fri, 08 May 2009 17:47:27 +0200 Subject: [U-Boot] [PATCH 2/3] OMAP3: Rename interrupts.c to timer.c In-Reply-To: <20090507204121.GC3302@game.jcrosoft.org> References: <1241538086-7555-1-git-send-email-dirk.behme@googlemail.com> <1241538086-7555-2-git-send-email-dirk.behme@googlemail.com> <1241538086-7555-3-git-send-email-dirk.behme@googlemail.com> <20090507204121.GC3302@game.jcrosoft.org> Message-ID: <4A04540F.10507@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Dear Jean-Christophe, Jean-Christophe PLAGNIOL-VILLARD wrote: > On 17:41 Tue 05 May , Dirk Behme wrote: >> After removal of dublicated interrupt code, rename file to what it >> really does now. > I prefer to rename all files at the same time Then, please don't complain that you have "to do everything on your own and nobody helps you" ;) I would prefer that changes are done by the board maintainers and not by the custodian, though. > Btw please use git to show that you only rename the file without change I'm not sure that this works for non-custodians. Custodians can do git-rename and then send a patch to the mailing list. When a custodian sends such a patch, it is mainly for review only, and not to be applied somewhere (because it is already in git). This results then in something cpu/sa1100/{interrupts.c => timer.c} | 5 +- rename cpu/arm925t/{interrupts.c => timer.c} (99%) (from [1]). But this is only what normally 'diffstat' generates and what is totally ignored by 'patch' . I.e. in the part of the patch which is handled by 'patch' this info is totally missing. As far as I know 'patch' itself can't deal with file rename any other way than remove one file and create the other one with --- u-boot-main.orig/cpu/arm_cortexa8/omap3/interrupts.c +++ /dev/null --- /dev/null +++ u-boot-main/cpu/arm_cortexa8/omap3/timer.c So it's my understanding that non-custodians have to send a patch which can be applied everywhere by everyone by 'patch' utility, i.e. the part 'patch' deals with contains all information necessary. Do I miss anything? Best regards Dirk [1] http://lists.denx.de/pipermail/u-boot/2009-May/051921.html