[U-Boot] [PATCH] Canyonlands SATA harddisk driver

Wolfgang Denk
2009-05-28T19:22:56Z

Dear Kazuaki Ichinohe,

In message <4A0D36AA.5000508@fsi.co.jp> you wrote:
> This patch adds a SATA harddisk driver for the canyonlands.
> This patch is kernel driver's porting.
> This pach corresponded to not cmd_scsi but cmd_sata.

Stefan Roese acked your patch, but then Shinya Kuribayashi remarked:

| I'm fine with this patch applied or not, but this driver is too big.
| It has a lot of unused struct members, I'm not sure they'll be used
| in the future, though.

Can you please comment on this? Is this stuff indeed provisions for
later extensions that you have in your queue, or is it dead code that
can be removed?

Best regards,

Wolfgang Denk

--
DENX Software Engineering GmbH, MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
I'd like to meet the man who invented sex and see what he's working
on now.