[U-Boot] [U-BOot] new cpu(Ingenic), new board(PI)

[U-Boot] [U-BOot] new cpu(Ingenic), new board(PI)

[xiangfu_gmail]

there is a device name PI,
the CPU is Ingenic 4740 [1],
now we have the u-boot-1.1.6 patch.[2]

I want the u-boot Integrate with 'upstream'
what am I got do.
just give some advice or step.


very thanks


[1]: a Chinese company.
http://www.ingenic.cn/pfwebplus/productServ/App/JZ4740/pfCustomPage.aspx
[2]:
http://code.google.com/p/pi-project/source/browse/trunk/u-boot/patchs/u-boot-1.1.6-jz-20090306.patch


Xiangfu
Blog: http://www.openmobilefree.net

[U-Boot] [U-BOot] new cpu(Ingenic), new board(PI)

[Wolfgang Denk]

Dear xiangfu_gmail,

In message <49E5A2ED.2060503@gmail.com> you wrote:
> there is a device name PI,
> the CPU is Ingenic 4740 [1],
> now we have the u-boot-1.1.6 patch.[2]
> 
> I want the u-boot Integrate with 'upstream'
> what am I got do.
> just give some advice or step.

Please see http://www.denx.de/wiki/U-Boot/CodingStyle and
http://www.denx.de/wiki/U-Boot/Patches .

We appreciate if you submit your patches following the above
guidelines - but you got to spend a lot of work before being able to
do that. U-Boot 1.1.6 is extremely old, so you must rebase your code
first against current top of tree.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
"They that can give up essential liberty to obtain a little temporary
saftey deserve neither liberty not saftey." - Benjamin Franklin, 1759

[U-Boot] [U-BOot] new cpu(Ingenic), new board(PI)

[xiangfu_gmail]

Hi Wolfgang.
if I have any progress  ,
I will send it to this list.

thanks
Xiangfu
Best Regards.

Wolfgang Denk wrote:
> Dear xiangfu_gmail,
>
> In message <49E5A2ED.2060503@gmail.com> you wrote:
>   
>> there is a device name PI,
>> the CPU is Ingenic 4740 [1],
>> now we have the u-boot-1.1.6 patch.[2]
>>
>> I want the u-boot Integrate with 'upstream'
>> what am I got do.
>> just give some advice or step.
>>     
>
> Please see http://www.denx.de/wiki/U-Boot/CodingStyle and
> http://www.denx.de/wiki/U-Boot/Patches .
>
> We appreciate if you submit your patches following the above
> guidelines - but you got to spend a lot of work before being able to
> do that. U-Boot 1.1.6 is extremely old, so you must rebase your code
> first against current top of tree.
>
> Best regards,
>
> Wolfgang Denk
>
>   

[U-Boot] new cpu(Ingenic), new board(PI)

[xiangfu_gmail]

Wolfgang Denk wrote:
> Dear xiangfu_gmail,
>
> In message <49E5A2ED.2060503@gmail.com> you wrote:
>   
>> there is a device name PI,
>> the CPU is Ingenic 4740 [1],
>> now we have the u-boot-1.1.6 patch.
>>
>>
>>     
I have try to add new device(PI) to u-boot.
when I compile the code I get error message:
------------------------------------
make[1]: Entering directory
`/home/xiangfu/workspace/pi-project/pi-u-boot/common'
mipsel-linux-gcc -g  -Os   -D__KERNEL__ -DTEXT_BASE=0x80100000
-I/home/xiangfu/workspace/pi-project/pi-u-boot/include -fno-builtin
-ffreestanding -nostdinc -isystem
/opt/mipseltools-gcc412-glibc261/lib/gcc/mipsel-linux/4.1.2/include
-pipe  -DCONFIG_MIPS -D__MIPS__ -G 0 -mabicalls -fpic -msoft-float
-march=4kc -mtune=4kc -EB -Wall -Wstrict-prototypes -fno-stack-protector
-c -o bedbug.o bedbug.c
bedbug.c: In function 'find_next_address':
bedbug.c:1081: error: 'struct pt_regs' has no member named 'nip'
bedbug.c:1089: error: 'struct pt_regs' has no member named 'ctr'
bedbug.c:1090: error: 'struct pt_regs' has no member named 'ccr'
bedbug.c:1091: error: 'struct pt_regs' has no member named 'link'
make[1]: *** [bedbug.o] Error 1
make[1]: Leaving directory
`/home/xiangfu/workspace/pi-project/pi-u-boot/common'
make: *** [common/libcommon.a] Error 2


give me some advice
very thanks.

you can find all the code at http://github.com/xiangfu/pi-u-boot/tree/master
and checkout branch "xiangfu"
it's the branch I try to merge with upstream.

[U-Boot] new cpu(Ingenic), new board(PI)

[Wolfgang Denk]

Dear xiangfu_gmail,

In message <4A101E59.8050505@gmail.com> you wrote:
>
> I have try to add new device(PI) to u-boot.
> when I compile the code I get error message:
...
> -c -o bedbug.o bedbug.c
> bedbug.c: In function 'find_next_address':
> bedbug.c:1081: error: 'struct pt_regs' has no member named 'nip'
> bedbug.c:1089: error: 'struct pt_regs' has no member named 'ctr'
> bedbug.c:1090: error: 'struct pt_regs' has no member named 'ccr'
> bedbug.c:1091: error: 'struct pt_regs' has no member named 'link'
...
> give me some advice

Well, obviously you have a problem with the dfitions for your CPU in
some of the header files. As I don't know your code (and I don't
review any out-of-tree repositories) I can just say that you should
fix your header files.  As a quick and dirty workaound you could also
disable KGDB support in your board configuration unless you really
need it.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Brain: an apparatus with which we think we think.    - Ambrose Bierce

[U-Boot] [U-BOot] new cpu(Ingenic), new board(PI)

[xiangfu]

Hi
Wolfgang Denk wrote:
> > Dear xiangfu_gmail,
> >
> > In message <49E5A2ED.2060503@gmail.com> you wrote:
>> >> there is a device name PI,
>> >> the CPU is Ingenic 4740 [1],
>> >> now we have the u-boot-1.1.6 patch.[2]
>> >>
>> >> I want the u-boot Integrate with 'upstream'
>> >> what am I got do.
>> >> just give some advice or step.
> >
> > Please see http://www.denx.de/wiki/U-Boot/CodingStyle and
> > http://www.denx.de/wiki/U-Boot/Patches .
> >
> > We appreciate if you submit your patches following the above
> > guidelines - but you got to spend a lot of work before being able to
> > do that. U-Boot 1.1.6 is extremely old, so you must rebase your code
> > first against current top of tree.
> >
Thanks Wolfgang.
Sorry for so later to reply your email.
those weeks I follow the CodingStyle, and also merge ingenic u-boot to
V2009.06.

for now it can not boot the kernel. but it's boot the device and output
something from the serial console.

there is two branch in my git[2].
[xiangfu] this one , I try to merge with the upstream.
[u-boot] is the upstream.

I use "git diff u-boot..xiangfu > ~/pi_project.patch" to generate the
patch[1].

what am I got do next?
thanks.


[1] http://www.openmobilefree.net/other/xiangfu/file/pi_project.patch
[2] http://github.com/xiangfu/pi-u-boot/tree/xiangfu

[U-Boot] [U-BOot] new cpu(Ingenic), new board(PI)

[Wolfgang Denk]

Dear xiangfu,

In message <4A21E74F.6080701@gmail.com> you wrote:
>
> there is two branch in my git[2].
> [xiangfu] this one , I try to merge with the upstream.
> [u-boot] is the upstream.
> 
> I use "git diff u-boot..xiangfu > ~/pi_project.patch" to generate the
> patch[1].

No. Please use git-format-patch to create patches.

Make sure to split your changes lgically into commits - the commits
should be small and orthogonal to each other. Please see
http://www.denx.de/wiki/U-Boot/Patches for details.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Pray: To ask that the laws of the universe be annulled in behalf of a
single petitioner confessedly unworthy.              - Ambrose Bierce

[U-Boot] [U-BOot] new cpu(Ingenic), new board(PI)

[xiangfu]

Wolfgang Denk wrote:
> Dear xiangfu,
> 
> In message <4A21E74F.6080701@gmail.com> you wrote:
>> there is two branch in my git[2].
>> [xiangfu] this one , I try to merge with the upstream.
>> [u-boot] is the upstream.
>>
>> I use "git diff u-boot..xiangfu > ~/pi_project.patch" to generate the
>> patch[1].
> 
> No. Please use git-format-patch to create patches.
> 
> Make sure to split your changes lgically into commits - the commits
> should be small and orthogonal to each other. Please see
> http://www.denx.de/wiki/U-Boot/Patches for details.
> 
> Best regards,
> 
> Wolfgang Denk
> 
Thanks for the reply.
I will need sometime to work, maybe 2~3 weeks.
because I have some other important work must to do.

I will keep send email if I have progress on U-boot.

-- 
Best Regards
Xiangfu Liu

jabber : xiangfu.z at gmail.com
skype  : xiangfu.z