* [U-Boot] [PATCH] fix accidental erase of OneNand whole chip
@ 2009-05-18 12:00 Geiger Ho
2009-05-19 22:36 ` Scott Wood
0 siblings, 1 reply; 2+ messages in thread
From: Geiger Ho @ 2009-05-18 12:00 UTC (permalink / raw)
To: u-boot
This patch fixes the accidental erase of OneNand whole chip when issuing
command "onenand erase".
Signed-off-by: Geiger Ho <geiger.ho@fmp.fujitsu.com>
--- u-boot-2009.03/common/cmd_onenand.c 2009-03-22 05:04:41.000000000 +0800
+++ u-boot-2009.03-dev/common/cmd_onenand.c 2009-05-18
17:57:27.000000000 +0800
@@ -367,6 +367,8 @@ int do_onenand(cmd_tbl_t * cmdtp, int fl
return 0;
}
+ goto usage;
+
default:
/* At least 4 args */
^ permalink raw reply [flat|nested] 2+ messages in thread
* [U-Boot] [PATCH] fix accidental erase of OneNand whole chip
2009-05-18 12:00 [U-Boot] [PATCH] fix accidental erase of OneNand whole chip Geiger Ho
@ 2009-05-19 22:36 ` Scott Wood
0 siblings, 0 replies; 2+ messages in thread
From: Scott Wood @ 2009-05-19 22:36 UTC (permalink / raw)
To: u-boot
On Mon, May 18, 2009 at 08:00:43PM +0800, Geiger Ho wrote:
> This patch fixes the accidental erase of OneNand whole chip when issuing
> command "onenand erase".
>
> Signed-off-by: Geiger Ho <geiger.ho@fmp.fujitsu.com>
>
>
> --- u-boot-2009.03/common/cmd_onenand.c 2009-03-22 05:04:41.000000000 +0800
> +++ u-boot-2009.03-dev/common/cmd_onenand.c 2009-05-18
> 17:57:27.000000000 +0800
> @@ -367,6 +367,8 @@ int do_onenand(cmd_tbl_t * cmdtp, int fl
> return 0;
> }
>
> + goto usage;
> +
> default:
> /* At least 4 args */
>
While that "at least 4 args" comment seems wrong, I don't think this
patch is correct -- there is code in the default block that checks argc
and expects to get there with argc == 2 in some cases.
How does accidental erasing occur?
-Scott
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2009-05-19 22:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-05-18 12:00 [U-Boot] [PATCH] fix accidental erase of OneNand whole chip Geiger Ho
2009-05-19 22:36 ` Scott Wood
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox