From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shinya Kuribayashi <skuribay@pobox.com>
Date: Sun, 24 May 2009 00:45:22 +0900
Subject: [U-Boot] [PATCH 2/2 V2] mips: unify lds
In-Reply-To: <1243078501-27652-2-git-send-email-plagnioj@jcrosoft.com>
References: <4A0E3A20.5010900@pobox.com>
	<1243078501-27652-1-git-send-email-plagnioj@jcrosoft.com>
	<1243078501-27652-2-git-send-email-plagnioj@jcrosoft.com>
Message-ID: <4A181A12.8050502@pobox.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Jean-Christophe PLAGNIOL-VILLARD wrote:
> all mips boards except a few use the same cpu lds so move it to cpu/$(CPU)
> 
> that could be overwrite in following order
> SOC
> BOARD
> via the corresponding config.mk
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>

Looks good, except for one nit.

> diff --git a/board/micronas/vct/u-boot.lds b/cpu/mips/u-boot.lds
> similarity index 75%
> rename from board/micronas/vct/u-boot.lds
> rename to cpu/mips/u-boot.lds
> index b90b186..dda0dda 100644
> --- a/board/micronas/vct/u-boot.lds
> +++ b/cpu/mips/u-boot.lds
> @@ -1,5 +1,8 @@
>  /*
> - * (C) Copyright 2003
> + * (C) Copyright 2004
> + * Masami Komiya <mkomiya@sonare.it>
> + *
> + * (C) Copyright 2003-2005
>   * Wolfgang Denk Engineering, <wd@denx.de>
>   *
>   * See file CREDITS for list of people who contributed to this

You probably just referred to the tb0229/u-boot.lds, but we'd like to
see here Wolfgang first.

  Shinya