public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Dirk Behme <dirk.behme@googlemail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCHv3 3/5] omap3: remove typedefs for configuration structs
Date: Sun, 24 May 2009 18:30:59 +0200	[thread overview]
Message-ID: <4A197643.7000000@googlemail.com> (raw)
In-Reply-To: <20090524161212.GA27630@game.jcrosoft.org>

Dear Jean-Christophe,

Jean-Christophe PLAGNIOL-VILLARD wrote:
>>>>  void beagle_identify(void)
>>>>  {
>>>> -	gpio_t *gpio6_base = (gpio_t *)OMAP34XX_GPIO6_BASE;
>>>> +	struct gpio *gpio6_base = (struct gpio *)OMAP34XX_GPIO6_BASE;
>>> please use a namespace name gpio is too much generic
>>> and it's the same for the other struct sms, pm etc...
>>> omap_ will be better as the omap4 will certanly use the same or near IP
>> But OMAP4 most probably will not use a file board/omap3/beagle/beagle.c.
>>
>> And using "omap_" would be wrong if your argument is OMAP4. Then it  
>> needs at least to be "omap3_".
>>
>> And I can't see how a local variable could pollute the namespace, if  
>> this is what you mean.
> where did I speak about var name?

Nowhere, sorry. I talk about it. Please replace string 'local 
variable' by 'local struct' above if you think it fits better.

> the stuct name need to be less generic

Why? Please see my arguments why I think it's fine as done in 
Matthias' patch.

Best regards

Dirk

  reply	other threads:[~2009-05-24 16:30 UTC|newest]

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-19  7:09 [U-Boot] [PATCHv3 0/5] clean up omap3 configuration structs Matthias Ludwig
2009-05-19  7:09 ` [U-Boot] [PATCHv3 1/5] OMAP3EVM: net_chip uses CS5 not CS6 Matthias Ludwig
2009-05-19  7:09   ` [U-Boot] [PATCHv3 2/5] omap3: embedd gpmc_cs into gpmc config struct Matthias Ludwig
2009-05-19  7:09     ` [U-Boot] [PATCHv3 3/5] omap3: remove typedefs for configuration structs Matthias Ludwig
2009-05-19  7:09       ` [U-Boot] [PATCHv3 4/5] omap3: replace all instances of gpmc config struct by one global Matthias Ludwig
2009-05-19  7:09         ` [U-Boot] [PATCHv3 5/5] omap3: use only fixed-size types inside ctrl_structs Matthias Ludwig
2009-05-24 15:49       ` [U-Boot] [PATCHv3 3/5] omap3: remove typedefs for configuration structs Jean-Christophe PLAGNIOL-VILLARD
2009-05-24 16:12         ` Dirk Behme
2009-05-24 16:12           ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-24 16:30             ` Dirk Behme [this message]
2009-05-24 19:58               ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-24 20:22                 ` Wolfgang Denk
2009-08-07 21:39       ` Wolfgang Denk
2009-08-07 21:32     ` [U-Boot] [PATCHv3 2/5] omap3: embedd gpmc_cs into gpmc config struct Wolfgang Denk
2009-05-24 15:42   ` [U-Boot] [PATCHv3 1/5] OMAP3EVM: net_chip uses CS5 not CS6 Jean-Christophe PLAGNIOL-VILLARD
2009-06-02 10:31     ` [U-Boot] [PATCH] OMAP3EVM: fix typo. replace CS6 by CS5, no functionality change Matthias Ludwig
2009-06-04 20:25       ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-08 11:48         ` Matthias Ludwig
2009-05-20 20:21 ` [U-Boot] [PATCHv3 0/5] clean up omap3 configuration structs Dirk Behme

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A197643.7000000@googlemail.com \
    --to=dirk.behme@googlemail.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox