From: Ben Warren <biggerbadderben@gmail.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH v2 0/3][Net][ARM] Davinci Ethernet driver cleanup
Date: Tue, 26 May 2009 09:34:25 -0700 [thread overview]
Message-ID: <4A1C1A11.3080009@gmail.com> (raw)
In-Reply-To: <C9D59C82B94F474B872F2092A87F2614816A1FB4@dlee07.ent.ti.com>
Hi Sandeep,
aulraj, Sandeep wrote:
> Ben,
> I believe there was a comment regrading the name of the file.
> The present name is dm644x_emac.c and it should be davinci_emac.c
> Because other floavours of DaVinci will use the same file.
>
> IIRC in the list had the same comment.
> Also the patch uses "dm644x_emac_initialize"
> It would be better to use davinci_emac_initialize.
>
> There are not big changes and I can send in a patch if its is
> ok with you.
>
> Thanks,
> Sandeep
>
>
It's better for me to redo the patch set. I named them based on
comments in the header of the source file.
regards,
Ben
prev parent reply other threads:[~2009-05-26 16:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-26 8:06 [U-Boot] [PATCH v2 0/3][Net][ARM] Davinci Ethernet driver cleanup Ben Warren
2009-05-26 8:06 ` [U-Boot] [PATCH v2 1/3][Net][ARM] Moved Davinci Ethernet driver to drivers/net Ben Warren
2009-05-26 8:06 ` [U-Boot] [PATCH v2 2/3][Net][ARM] Initial cleanup of Davinci Ethernet driver Ben Warren
2009-05-26 8:06 ` [U-Boot] [PATCH v2 3/3][Net][ARM] Switched dm644x_emac Ethernet driver to use newer API Ben Warren
2009-05-26 12:15 ` [U-Boot] [PATCH v2 0/3][Net][ARM] Davinci Ethernet driver cleanup Paulraj, Sandeep
2009-05-26 16:34 ` Ben Warren [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1C1A11.3080009@gmail.com \
--to=biggerbadderben@gmail.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox