From: Felix Radensky <felix@embedded-sol.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Incorrect MDIO clock setup in 4xx network driver
Date: Thu, 28 May 2009 23:20:26 +0300 [thread overview]
Message-ID: <4A1EF20A.5040807@embedded-sol.com> (raw)
Hi,
The following piece of code in ppc_4xx_eth_init() results in incorrect MDIO
clock setup on Canyonlands, in the case when OPB clock is 100Mhz
/* Whack the M1 register */
mode_reg = 0x0;
mode_reg &= ~0x00000038;
if (sysinfo.freqOPB <= 50000000);
else if (sysinfo.freqOPB <= 66666667)
mode_reg |= EMAC_M1_OBCI_66;
else if (sysinfo.freqOPB <= 83333333)
mode_reg |= EMAC_M1_OBCI_83;
else if (sysinfo.freqOPB <= 100000000)
mode_reg |= EMAC_M1_OBCI_100;
else
mode_reg |= EMAC_M1_OBCI_GT100;
out_be32((void *)EMAC_M1 + hw_p->hw_addr, mode_reg);
When OPB clock runs at 100Mhz, the value of sysinfo.freqOPB is 100000001,
so this code configures MDC clock to 3.3Mhz instead of less than 2.5Hz. This
is not a problem on Canyonlands, where Marvell PHY MDIO clock can run at
8.3Mhz. However other PHYs may actually require MDIO clock to be less than
2.5Mhz.
How about rewriting this code as
freq = sysinfo.freqOPB / 1000000;
if (freq <= 50)
else if (freq <= 66)
mode_reg |= EMAC_M1_OBCI_66;
else if (freq <= 83)
mode_reg |= EMAC_M1_OBCI_83;
else if (freq <= 100)
mode_reg |= EMAC_M1_OBCI_100;
else
mode_reg |= EMAC_M1_OBCI_GT100;
Felix.
next reply other threads:[~2009-05-28 20:20 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-28 20:20 Felix Radensky [this message]
2009-05-29 5:03 ` [U-Boot] Incorrect MDIO clock setup in 4xx network driver Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A1EF20A.5040807@embedded-sol.com \
--to=felix@embedded-sol.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox