From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Warren Date: Sun, 31 May 2009 20:55:22 -0700 Subject: [U-Boot] [PATCH] net: Add Marvell Kirkwood gigabit ethernet driver In-Reply-To: <73173D32E9439E4ABB5151606C3E19E201CFBDC5A4@SC-VEXCH1.marvell.com> References: <73173D32E9439E4ABB5151606C3E19E201CFBDC5A4@SC-VEXCH1.marvell.com> Message-ID: <4A23512A.1020801@gmail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Prafulla Wadaskar wrote: > > > >> -----Original Message----- >> From: Ben Warren [mailto:biggerbadderben at gmail.com] >> Sent: Saturday, May 30, 2009 4:51 AM >> To: Jean-Christophe PLAGNIOL-VILLARD >> Cc: Prafulla Wadaskar; u-boot at lists.denx.de; Manas Saksena; >> Ronen Shitrit; Nicolas Pitre; Ashish Karkare; Prabhanjan >> Sarnaik; Lennert Buijtenhek >> Subject: Re: [U-Boot] [PATCH] net: Add Marvell Kirkwood >> gigabit ethernet driver >> >> Jean-Christophe PLAGNIOL-VILLARD wrote: >> >>> On 01:13 Sat 30 May , Prafulla Wadaskar wrote: >>> >>> >>>> This patch adds a egiga driver for the Marvell Kirkwood SoC's. >>>> >>>> Contributors: >>>> Yotam Admon >>>> Michael Blostein >>> >>>> Reviewed-by: Ronen Shitrit >>>> Acked-by: Stefan Rose >>>> Signed-off-by: Prafulla Wadaskar >>>> >>>> >>> Ben if it's ok for you I'll apply with rest of the series >>> >>> Best Regards, >>> J. >>> >>> >> I'll look at it this weekend. >> > Hi Ben, > I have put the huge efforts to tune it specially for code size reduction. > Whereas I have lost only network statistics and packet info print debugging features. > Now it looks more simpler and cleaner :-) > Hopefully it will stand as per your suggestions. > > Much appreciated! Thanks a lot. It looks really good - please just take care of Wolfgang's concerns about error messages and it'll be ready for inclusion. regards, Ben