From: Renaud barbier <renaud.barbier@ge.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RFC/PATCH] jffs2/mtdparts: Fix problem with usage from JFFS2 and MTDPARTS together
Date: Mon, 01 Jun 2009 09:59:16 +0100 [thread overview]
Message-ID: <4A239864.1000408@ge.com> (raw)
In-Reply-To: <20090528192705.A8814832E416@gemini.denx.de>
Wolfgang Denk wrote:
> Dear Stefan Roese,
>
> In message <1242468262-25814-1-git-send-email-sr@denx.de> you wrote:
>
>> Currently using JFFS2 with MTDPARTS enabled doesn't work. This is because
>> mtdparts_init() is available in both files, cmd_mtdparts.c and
>> cmd_jffs2.c. Please note that in the original cmd_jffs2.c file (before
>> the jffs2/mtdparts command/file split those 2 different versions
>> already existed. So this is nothing new. The main problem is that the
>> variables "current_dev" and "current_partnum" are declared in both
>> files now. This doesn't work.
>>
>> This patch now changes the names of those variable to more specific
>> names: "current_mtd_dev" and "current_mtd_partnum". This is because
>> this patch also changes the declaration from static to global, so
>> that they can be used from both files.
>>
>> Please note that my first tests were not successful. The MTD devices
>> selected via mtdparts are now accessed but I'm failing to see the
>> directory listed via the "ls" command. Nothing is displayed. Perhaps
>> I didn't generate the JFFS2 image correctly (I never used JFFS2 in
>> U-Boot before). Not sure. Perhaps somebody else could take a look at
>> this as well. I'll continue looking into this on Monday.
>>
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Wolfgang Denk <wd@denx.de>
>> Cc: Detlev Zundel <dzu@denx.de>
>> Cc: Ilya Yanok <yanok@emcraft.com>
>> Cc: Renaud barbier <renaud.barbier@ge.com>
>> ---
>> Renaud, you reported this problem on 05-04-2009 [mtdparts and JFFS2]. Could you
>> please take a look at my patch. Does this work for you? Or what else is missing?
>>
This works for me.
I had the "ls" problem before when current_mtd_dev was not declare global.
This was because as a static current_mtd_dev. was NULL.
>> Thank,
>> Stefan.
>>
>> common/cmd_jffs2.c | 44 ++++++++++++++++++-----------
>> common/cmd_mtdparts.c | 74 ++++++++++++++++++++++++------------------------
>> 2 files changed, 64 insertions(+), 54 deletions(-)
>>
>
> Applied to master, thanks.
>
> Best regards,
>
> Wolfgang Denk
>
>
next prev parent reply other threads:[~2009-06-01 8:59 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-05-16 10:04 [U-Boot] [RFC/PATCH] jffs2/mtdparts: Fix problem with usage from JFFS2 and MTDPARTS together Stefan Roese
2009-05-17 13:54 ` Wolfgang Denk
2009-05-20 10:01 ` Stefan Roese
2009-05-24 21:10 ` Wolfgang Denk
2009-05-26 19:48 ` Scott Wood
2009-05-17 14:52 ` Wolfgang Denk
2009-05-17 17:25 ` Wolfgang Denk
2009-05-20 9:54 ` Stefan Roese
2009-05-28 19:27 ` Wolfgang Denk
2009-06-01 8:59 ` Renaud barbier [this message]
2009-06-02 3:58 ` Stefan Roese
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A239864.1000408@ge.com \
--to=renaud.barbier@ge.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox