[U-Boot] [PATCH v2 2/3] MX31: Add basic support for Freescale i.MX31 PDK board.

Magnus Lilja
2009-05-11T06:47:40Z

2009/5/10 Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>:
>> >> @@ -0,0 +1,59 @@
>> >> +/*
>> >> + * You should have received a copy of the GNU General Public License
>> >> + * along with this program; if not, write to the Free Software
>> >> + * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
>> >> + * MA 02111-1307 USA
>> >> + */
>> >> +
>> >> +#ifndef __CONFIG_H
>> >> +#define __CONFIG_H
>> >> +
>> >> +#include <asm/arch/mx31-regs.h>
>> > why?
>>
>> So we can use symbolic names for Ethernet base address, SDRAM base
>> address. I.e. instead of writing e.g. 0xB6000000 we can write
>> CS5_BASE. I can switch to hard coded numerical values and get rid of
>> the #include if requested.
> if you include it in the final c files
> you do not need to include mx31-regs.h always

That works for SoC files, but not for the Ethernet-driver. I don't
think the idea is to add #include mx31-regs.h to drivers/net/sms911x.c
so I think I have to write the 0xB6.... there.

Regards, Magnus