From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] TSEC ethernet controller problems (crc errors/ corruption)
Date: Wed, 03 Jun 2009 17:41:49 -0400 [thread overview]
Message-ID: <4A26EE1D.9020405@windriver.com> (raw)
In-Reply-To: <20090603151905.b191e4b0.kim.phillips@freescale.com>
Kim Phillips wrote:
> On Wed, 3 Jun 2009 10:50:25 -0700
> Ira Snyder <iws@ovro.caltech.edu> wrote:
...
>>
>> In practice, this doesn't seem to make a difference on the MPC8349EMDS
>> eval board. Both settings work without any errors. For people like me,
>> who are copying an existing board port to a similar board, it would be
>> nice if it was correct.
>
> granted. I'm betting the sbc8349 and tqm834x just copied the setting
You would be correct (at least for the sbc).
> from the MDS code, so those should get 0 too. Board maintainers,
> please test:
I won't be able to test this on an sbc until later this week,
but don't let that stop you from queueing it up; I suspect it
will just be a formality.
Thanks,
Paul.
> diff --git a/include/configs/sbc8349.h b/include/configs/sbc8349.h
> index d0338f1..edd928d 100644
> --- a/include/configs/sbc8349.h
> +++ b/include/configs/sbc8349.h
> @@ -519,7 +519,7 @@
> #endif
>
> /* System IO Config */
> -#define CONFIG_SYS_SICRH SICRH_TSOBI1
> +#define CONFIG_SYS_SICRH 0
> #define CONFIG_SYS_SICRL SICRL_LDP_A
>
> #define CONFIG_SYS_HID0_INIT 0x000000000
>
> Thanks,
>
> Kim
next prev parent reply other threads:[~2009-06-03 21:41 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-02 16:27 [U-Boot] TSEC ethernet controller problems (crc errors / corruption) Ira Snyder
2009-06-02 16:42 ` David Hawkins
2009-06-02 17:35 ` Peter Tyser
2009-06-02 18:17 ` David Hawkins
2009-06-02 18:17 ` Ira Snyder
2009-06-02 18:41 ` Kim Phillips
2009-06-02 18:50 ` Wolfgang Denk
2009-06-02 19:01 ` David Hawkins
2009-06-02 19:46 ` Ira Snyder
2009-06-02 20:38 ` [U-Boot] TSEC ethernet controller problems (crc errors/ corruption) Liu Dave-R63238
2009-06-02 20:44 ` Liu Dave-R63238
2009-06-02 21:25 ` Ira Snyder
2009-06-02 22:10 ` [U-Boot] TSEC ethernet controller problems (crc errors/corruption) Liu Dave-R63238
2009-06-02 22:19 ` [U-Boot] TSEC ethernet controller problems (crc errors/ corruption) Ira Snyder
2009-06-02 22:22 ` [U-Boot] TSEC ethernet controller problems (crc errors/corruption) Liu Dave-R63238
2009-06-02 23:08 ` [U-Boot] TSEC ethernet controller problems (crc errors/ corruption) Kim Phillips
2009-06-03 17:50 ` Ira Snyder
2009-06-03 20:19 ` Kim Phillips
2009-06-03 20:46 ` Ira Snyder
2009-06-03 21:41 ` Paul Gortmaker [this message]
2009-06-05 18:45 ` Paul Gortmaker
2009-06-06 0:38 ` Kim Phillips
2009-06-06 2:31 ` dwh at ovro.caltech.edu
2009-06-08 15:50 ` Kim Phillips
2009-06-08 16:46 ` David Hawkins
2009-06-08 23:06 ` Liu Dave-R63238
2009-06-08 23:36 ` David Hawkins
2009-06-09 21:46 ` David Hawkins
2009-06-09 23:21 ` Liu Dave-R63238
2009-06-09 23:35 ` David Hawkins
2009-06-03 21:51 ` [U-Boot] TSEC ethernet controller problems (crc errors/corruption) Liu Dave-R63238
2009-06-03 21:58 ` David Hawkins
2009-06-02 22:30 ` Liu Dave-R63238
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A26EE1D.9020405@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox