From mboxrd@z Thu Jan  1 00:00:00 1970
From: Heiko Schocher <hs@denx.de>
Date: Sat, 06 Jun 2009 08:23:57 +0200
Subject: [U-Boot] Adding a composite device, how to structure ?
In-Reply-To: <4A296B3C.1060208@windriver.com>
References: <4A296B3C.1060208@windriver.com>
Message-ID: <4A2A0B7D.7060609@denx.de>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hello Tom,

Tom wrote:
> I would like to add support for the twl4030,  a composite i2c device, 
> found on the omap3 zoom's.
> The header file will be include/twl4030.h.
> How do you want the source to be structured ?
> 1.  A single large file in drivers/i2c/twl4030.c
> 
> or device files added under a directory ?
> 
> 2.  drivers/i2c/twl4030/keyboard, drivers/i2c/twl4030/usb,  
> drivers/i2c/twl4030/battery, 
> 
> or just the common code in i2c and twl4030 devices in the  places they 
> usually go.
> 
> 3.  drivers/i2c/twl4030.c, drivers/usb/tw4030_usb.c  etc ..
> 
> My guess is #3.

Yep, I think #3 is the right way to go.

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany