public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Heiko Schocher <hs@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] mpc512x: Fix problem with I2C access before relocation
Date: Mon, 08 Jun 2009 12:33:01 +0200	[thread overview]
Message-ID: <4A2CE8DD.5030502@denx.de> (raw)
In-Reply-To: <20090608102501.A8037832E416@gemini.denx.de>

Hello Wolfgang,

Wolfgang Denk wrote:
> Dear Stefan Roese,
> 
> In message <1244446687-11316-1-git-send-email-sr@denx.de> you wrote:
>> This is needed for the upcoming esd MECP5123 board port which uses I2C EEPROM
>> for environment storage.
> 
> Stefan, please  check  if  this  is  really  what  you  want  to  do.
> Environmentin EEPROM is *strongly* discouraged. It is slow like hell,
> and  even more unreliable. Do *not* do this. Check if you can use any
> other storage - NOR or NAND flash, or the like.
> 
>> Signed-off-by: Stefan Roese <sr@denx.de>
>> Cc: Reinhard Arlt <reinhard.arlt@esd-electronics.com>
>> ---
>>  cpu/mpc512x/i2c.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
> Heiko, if Stefan does not change his mind, then I suggest you ACK the
> patch and I apply it then to the 5xxx repo?

This Patch is okay, independent if Stefan changes his mind or
not, I think. Thanks to Stefan for finding this.

Acked-by: Heiko Schocher<hs@denx.de>

bye
Heiko
-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany

  reply	other threads:[~2009-06-08 10:33 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-08  7:38 [U-Boot] [PATCH] mpc512x: Fix problem with I2C access before relocation Stefan Roese
2009-06-08 10:25 ` Wolfgang Denk
2009-06-08 10:33   ` Heiko Schocher [this message]
2009-06-08 16:44     ` Stefan Roese
2009-06-08 16:48   ` Stefan Roese
2009-06-08 18:05     ` Wolfgang Denk
2009-06-12 13:01 ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A2CE8DD.5030502@denx.de \
    --to=hs@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox