From mboxrd@z Thu Jan  1 00:00:00 1970
From: Grzegorz Bernacki <gjb@semihalf.com>
Date: Wed, 10 Jun 2009 16:03:42 +0200
Subject: [U-Boot] [PATCH v2 2/3] digsy MTC: Add SPI support.
In-Reply-To: <m2k53k2u8n.fsf@ohwell.denx.de>
References: <1244549692-68089-1-git-send-email-gjb@semihalf.com>	<1244549692-68089-2-git-send-email-gjb@semihalf.com>
	<m2k53k2u8n.fsf@ohwell.denx.de>
Message-ID: <4A2FBD3E.9000602@semihalf.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de


> 
>> +#ifdef CONFIG_MPC52XX_SPI
>> +	/* SPI on Tmr2/3/4/5 pins */
>> +	setbits_be32(&gpio->port_config, (1 << 29));
> 
> Sorry for missing this on the first round, but as this is always defined
> we should work this into CONFIG_SYS_GPS_PORT_CONFIG in digsy_mtc.h.  A
> comment explaining this (as far as easily possible) would also be nice.
> include/configs/inka4x0.h is a nice example on how to do this.
> 

Setting this bit is unnecessary since it is already set in
CONFIG_SYS_GPS_PORT_CONFIG which is used in digsy. I will create
another patch in which I add some comment to this define.

Grzesiek