From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 3/4] ZOOM2 Add power reset button
Date: Fri, 12 Jun 2009 08:02:23 -0500 [thread overview]
Message-ID: <4A3251DF.3070104@windriver.com> (raw)
In-Reply-To: <20090610202728.GD2080@game.jcrosoft.org>
Jean-Christophe PLAGNIOL-VILLARD wrote:
>> How about this:
>>
>> Regarding Dirk's and Heiko's comment:
>> A) How about board/omap3/common/power.c to drivers/power/twl4030.c
>>
> Ack
> but I've a patch for Dirk in my queued that I need to process about it
> so we have 2 choice
> 1) apply Dirk's patch first and the move the code to drivers/power
> 2) rewrite a patch against the next
>
>
Please forward me the patch,
I will merge it into the drivers/power/twl4030.c I am creating.
> I've in mind to do the 1) to mention in the changelog Dirk's work
>
>> On patch [PATCH 2/4] I2C Add initial support for TWL4030:
>> B) introduce a new header in include/twl4030.h from Tom's patch
>> Remove drivers/i2c/twl4030_i2c.c from the patch instead add:
>> #define TWLL4030_READ_U8(MODULE, VAL,REG)\
>> i2c_read((MODULE), (REG), 1, (VAL), 1)
>> #define TWLL4030_WRITE_U8(MODULE, VAL,REG)\
>> i2c_read((MODULE), (REG), 1, (VAL), 1)
>> to include/twl4030.h in the patch.
>>
> please use inline function for this
>
>
Yes.
I am doing adding this to twl4030.h
static inline int twl4030_i2c_read_u8(u8 chip_no, u8 *val, u8 reg) {}
> Best Regards,
> J.
>
next prev parent reply other threads:[~2009-06-12 13:02 UTC|newest]
Thread overview: 44+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-10 12:53 [U-Boot] Zoom hw reset Tom Rix
2009-06-10 12:53 ` [U-Boot] [PATCH 1/4] OMAP3 I2C Fix the sampling clock Tom Rix
2009-06-10 12:53 ` [U-Boot] [PATCH 2/4] I2C Add initial support for TWL4030 Tom Rix
2009-06-10 12:53 ` [U-Boot] [PATCH 3/4] ZOOM2 Add power reset button Tom Rix
2009-06-10 12:53 ` [U-Boot] [PATCH 4/4] ZOOM1 " Tom Rix
2009-06-12 21:46 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-12 21:57 ` Tom
2009-06-12 23:08 ` Menon, Nishanth
2009-06-13 2:28 ` Tom
2009-06-13 14:16 ` Tom
2009-06-13 14:26 ` Nishanth Menon
2009-06-10 14:27 ` [U-Boot] [PATCH 3/4] ZOOM2 " Peter Tyser
2009-06-10 14:43 ` Menon, Nishanth
2009-06-10 15:43 ` Dirk Behme
2009-06-10 16:16 ` Menon, Nishanth
2009-06-10 16:25 ` Peter Tyser
2009-06-10 18:08 ` Heiko Schocher
2009-06-10 18:27 ` Menon, Nishanth
2009-06-10 18:21 ` Heiko Schocher
2009-06-10 18:50 ` Menon, Nishanth
2009-06-10 20:27 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-12 13:02 ` Tom [this message]
2009-06-13 14:27 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-10 18:06 ` Heiko Schocher
2009-06-10 18:04 ` Heiko Schocher
2009-06-10 17:56 ` Heiko Schocher
2009-06-10 17:48 ` Heiko Schocher
2009-06-10 14:46 ` [U-Boot] [PATCH 2/4] I2C Add initial support for TWL4030 Menon, Nishanth
2009-06-10 17:59 ` Heiko Schocher
2009-06-10 17:45 ` Heiko Schocher
2009-07-19 9:19 ` Wolfgang Denk
2009-07-19 15:23 ` Heiko Schocher
2009-07-19 17:06 ` Tom
2009-07-20 9:12 ` Heiko Schocher
2009-07-22 21:41 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-20 15:38 ` Dirk Behme
2009-06-10 14:52 ` [U-Boot] [PATCH 1/4] OMAP3 I2C Fix the sampling clock Menon, Nishanth
2009-06-11 2:43 ` Tom
2009-06-11 4:12 ` Menon, Nishanth
2009-06-11 14:02 ` Tom
2009-06-12 21:44 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-12 22:06 ` Tom
2009-06-17 22:31 ` [U-Boot] RFC " Tom
2009-06-12 21:41 ` [U-Boot] " Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A3251DF.3070104@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox