public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Mark Jackson <mpfj-list@mimc.co.uk>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] Atmel LCD driver GUARDTIME fix
Date: Tue, 16 Jun 2009 13:46:34 +0100	[thread overview]
Message-ID: <4A37942A.20607@mimc.co.uk> (raw)

This patch correctly sets up the guard time parameter in
the Atmel LCDC driver.

This works on the AVR32 platform, but needs to be tested
under the AT91 platform which shares the same code base.

Signed-off-by: Mark Jackson <mpfj@mimc.co.uk>
---
  drivers/video/atmel_lcdfb.c |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 3a51cc7..14f578e 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -42,6 +42,7 @@ short console_row;
  /* configurable parameters */
  #define ATMEL_LCDC_CVAL_DEFAULT		0xc8
  #define ATMEL_LCDC_DMA_BURST_LEN	8
+#define ATMEL_LCDC_GUARD_TIME		2

  #if defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91CAP9)
  #define ATMEL_LCDC_FIFO_SIZE		2048
@@ -69,7 +70,7 @@ void lcd_ctrl_init(void *lcdbase)

  	/* Turn off the LCD controller and the DMA controller */
  	lcdc_writel(panel_info.mmio, ATMEL_LCDC_PWRCON,
-		    1 << ATMEL_LCDC_GUARDT_OFFSET);
+		    ATMEL_LCDC_GUARD_TIME << ATMEL_LCDC_GUARDT_OFFSET);

  	/* Wait for the LCDC core to become idle */
  	while (lcdc_readl(panel_info.mmio, ATMEL_LCDC_PWRCON) & ATMEL_LCDC_BUSY)
@@ -150,7 +151,7 @@ void lcd_ctrl_init(void *lcdbase)

  	lcdc_writel(panel_info.mmio, ATMEL_LCDC_DMACON, ATMEL_LCDC_DMAEN);
  	lcdc_writel(panel_info.mmio, ATMEL_LCDC_PWRCON,
-		    (1 << ATMEL_LCDC_GUARDT_OFFSET) | ATMEL_LCDC_PWR);
+		    (ATMEL_LCDC_GUARD_TIME << ATMEL_LCDC_GUARDT_OFFSET) | ATMEL_LCDC_PWR);
  }

  ulong calc_fbsize(void)

             reply	other threads:[~2009-06-16 12:46 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16 12:46 Mark Jackson [this message]
2009-06-21 14:28 ` [U-Boot] [PATCH] Atmel LCD driver GUARDTIME fix Jean-Christophe PLAGNIOL-VILLARD
2009-06-22  8:09   ` Mark Jackson
2009-06-22  8:48     ` Anatolij Gustschin
2009-06-22 15:27       ` Mark Jackson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A37942A.20607@mimc.co.uk \
    --to=mpfj-list@mimc.co.uk \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox