[U-Boot] PATCH: bugfix for nand erase failure with bad blocks

Michele De Candia
2009-06-16T19:51:27Z

Wolfgang Denk wrote:
> Dear "Michele De Candia (VT)",
>
> In message <4A3798C4.8000303@valueteam.com> you wrote:
>
>> this patch fixes a bug for 'nand erase' command: when bad blocks are
>> present into erasing area, they were skipped but the erased size was
>> updated anyway.
>>
>
> And what exactly is the bug in this behaviour?
>
I think that 'erase' should have the same behaviour of 'write' and
'read' commands: skip bad blocks until read/write size is reached. If
you write a script that erases and then writes a NAND area and bad
blocks are not skipped while erasing (as U-Boot actually does), the
following 'write' is successfully done but ECC checks fail on next read
on the same area.
> Given the fact that you don't know the number of bad blocks in
> advance, what do you use as reference for 100% in your display, then?
>
I used the size passed by the user from command line as target and the
actual erased size as reference while erasing blocks and skipping bad ones.
> Best regards,
>
> Wolfgang Denk
>
>

--

*Michele Jr **De Candia*

------------------------------------------------------------------------

Value Team

Via Vespri Siciliani, 9
20146 Milano
Tel. +39 0248985722
michele.decandia at valueteam.com <mailto:michele.decandia@valueteam.com>
http://www.valueteam.com

CONFIDENTIALITY NOTICE -This message and its attachments (if any) may
contain confidential, proprietary or legally privileged information and
is intended only for the use of the addressee named above. No
confidentiality or privilege is waived or lost by any mistransmission.
If you are not the intended recipient of this message you are hereby
notified that you must not use, disseminate, copy it in any form or take
any action in reliance on it. If you have received this message in error
please delete it and any copies of it and kindly inform the sender of
this e-mail by replying or go to www.valueteam.com
<http://www.valueteam.com> on 'contacts'.