From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Tue, 16 Jun 2009 13:20:42 -0700
Subject: [U-Boot] 83xx 85xx: UEC: Implicit declaration of function
	'uec_standard_init'
In-Reply-To: <4A37FB40.20907@RuggedCom.com>
References: <4A37FB40.20907@RuggedCom.com>
Message-ID: <4A37FE9A.7090704@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Richard,

Richard Retanubun wrote:
> Hi,
>
> Since rebasing to 2009.06 release, I have been getting this compiler warning
>
> cpu.c: In function 'cpu_eth_init':
> cpu.c:372: warning: implicit declaration of function 'uec_standard_init'
>
> It is declared in /drivers/qe/uec.h, crude hacks at including the header causes even more errors:
>
> In file included from cpu.c:35:
> ../../drivers/qe/uec.h:699: error: expected specifier-qualifier-list before 'ucc_fast_info_t'
> ../../drivers/qe/uec.h:722: error: expected specifier-qualifier-list before 'ucc_fast_private_t'
> In file included from cpu.c:37:
> /home/richardretanubun/workspace/u-boot/include/netdev.h:75: error: conflicting types for 'uec_initialize'
> ../../drivers/qe/uec.h:764: error: previous declaration of 'uec_initialize' was here
> make[1]: *** [cpu.o] Error 1
> make: *** [cpu/mpc83xx/libmpc83xx.a] Error 2
>
> The side effect I see so far is that the network interface can be used once (say for tftp) but fails after that.
>
> is there a patch missing for cpu.c?
>
> - Richard
>   
Looks like some networking code snuck in through the back door:

http://git.denx.de/?p=u-boot.git;a=commit;h=8e55258f144764de8902e9f078a7ad4c6c022c2f

include/netdev.h should contain the definitive public API for device 
initialization.

Does removing '#include "netdev.h' in cpu.c fix it?

regards,
Ben