From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ben Warren <biggerbadderben@gmail.com>
Date: Tue, 16 Jun 2009 13:33:57 -0700
Subject: [U-Boot] 83xx 85xx: UEC: Implicit declaration of function
	'uec_standard_init'
In-Reply-To: <4A380094.6080202@RuggedCom.com>
References: <4A37FB40.20907@RuggedCom.com> <4A37FE9A.7090704@gmail.com>
	<4A380094.6080202@RuggedCom.com>
Message-ID: <4A3801B5.1070809@gmail.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Richard,

Richard Retanubun wrote:
> Ben Warren wrote:
>> Hi Richard,
> [snip]
>> Looks like some networking code snuck in through the back door:
>>
>> http://git.denx.de/?p=u-boot.git;a=commit;h=8e55258f144764de8902e9f078a7ad4c6c022c2f 
>>
>>
>> include/netdev.h should contain the definitive public API for device 
>> initialization.
>>
>> Does removing '#include "netdev.h' in cpu.c fix it?
>
> Hi Ben,
>
> Thanks for the quick reply :)
Just sitting in my cube, waiting for a compile to finish :)
>
> If by '#include "netdev.h' in cpu.c you mean this:
>
> diff --git a/cpu/mpc83xx/cpu.c b/cpu/mpc83xx/cpu.c
> index c4331ae..dc463aa 100644
> --- a/cpu/mpc83xx/cpu.c
> +++ b/cpu/mpc83xx/cpu.c
> @@ -33,7 +33,8 @@
>  #include <asm/processor.h>
>  #include <libfdt.h>
>  #include <tsec.h>
> -#include <netdev.h>
> +#include "../../drivers/qe/uec.h"
>  #include <fsl_esdhc.h>
>  #ifdef CONFIG_BOOTCOUNT_LIMIT
>  #include <asm/immap_qe.h>
>
> Then no (well, it does fix the conflicting declaration of 
> uec_initialize between uec.h and netdev.h) but the error of:
>
> In file included from cpu.c:36:
> ../../drivers/qe/uec.h:699: error: expected specifier-qualifier-list 
> before 'ucc_fast_info_t'
> ../../drivers/qe/uec.h:722: error: expected specifier-qualifier-list 
> before 'ucc_fast_private_t'
> make[1]: *** [cpu.o] Error 1
> make: *** [cpu/mpc83xx/libmpc83xx.a] Error 2
>
> Still remains.
>
> - Richard
>
How about removing the  include "netdev.h" and adding:

extern int uec_standard_init(bd_t *bis);

IMHO this submission should be backed out - it looks like it wasn't 
properly baked.

regards,
Ben