From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] 83xx 85xx: UEC: Implicit declaration of function 'uec_standard_init'
Date: Wed, 17 Jun 2009 08:27:33 -0400 [thread overview]
Message-ID: <4A38E135.3030600@RuggedCom.com> (raw)
In-Reply-To: <92FFBBB1-7EC6-444C-9BF6-C37288608F9B@kernel.crashing.org>
Kumar Gala wrote:
>
> On Jun 16, 2009, at 3:50 PM, Richard Retanubun wrote:
>
>> [snip]
>>> How about removing the include "netdev.h" and adding:
>>>
>>> extern int uec_standard_init(bd_t *bis);
>>>
>> D'oh!
>>
>> diff --git a/cpu/mpc83xx/cpu.c b/cpu/mpc83xx/cpu.c
>> index c4331ae..f29b848 100644
>> --- a/cpu/mpc83xx/cpu.c
>> +++ b/cpu/mpc83xx/cpu.c
>> @@ -33,13 +33,14 @@
>> #include <asm/processor.h>
>> #include <libfdt.h>
>> #include <tsec.h>
>> -#include <netdev.h>
>> #include <fsl_esdhc.h>
>> #ifdef CONFIG_BOOTCOUNT_LIMIT
>> #include <asm/immap_qe.h>
>> #include <asm/io.h>
>> #endif
>>
>> +extern int uec_standard_init(bd_t *bis);
>> +
>> DECLARE_GLOBAL_DATA_PTR;
>>
>> int checkcpu(void)
>>
>>
>> Yeah, this works (if we want to patch it, better do it for the
>> cpu/mpc85xx/cpu.c also though) :)
>>
>>> IMHO this submission should be backed out - it looks like it wasn't
>>> properly baked.
>>
>> I'll let you make the call on that, the patch does introduce a nice
>> cleanup on a
>> problem I've compounded in the past so I am quite grateful for it.
>
> This is my bad.. I hope this patch isn't actually in v2009.06. (it
> wasn't intended to be).
>
> - k
Not sure if it is my turn to answer, but this is in v2009.06, as Ben stated before,
http://git.denx.de/?p=u-boot.git;a=commit;h=8e55258f144764de8902e9f078a7ad4c6c022c2f
- R
next prev parent reply other threads:[~2009-06-17 12:27 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-16 20:06 [U-Boot] 83xx 85xx: UEC: Implicit declaration of function 'uec_standard_init' Richard Retanubun
2009-06-16 20:20 ` Ben Warren
2009-06-16 20:29 ` Richard Retanubun
2009-06-16 20:33 ` Ben Warren
2009-06-16 20:50 ` Richard Retanubun
2009-06-16 21:16 ` Kumar Gala
2009-06-17 12:27 ` Richard Retanubun [this message]
2009-06-17 13:15 ` Kumar Gala
2009-06-17 13:22 ` Kumar Gala
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A38E135.3030600@RuggedCom.com \
--to=richardretanubun@ruggedcom.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox