From mboxrd@z Thu Jan  1 00:00:00 1970
From: Richard Retanubun <RichardRetanubun@RuggedCom.com>
Date: Wed, 17 Jun 2009 08:27:33 -0400
Subject: [U-Boot] 83xx 85xx: UEC: Implicit declaration of function
	'uec_standard_init'
In-Reply-To: <92FFBBB1-7EC6-444C-9BF6-C37288608F9B@kernel.crashing.org>
References: <4A37FB40.20907@RuggedCom.com> <4A37FE9A.7090704@gmail.com>
	<4A380094.6080202@RuggedCom.com> <4A3801B5.1070809@gmail.com>
	<4A38057E.5050001@RuggedCom.com>
	<92FFBBB1-7EC6-444C-9BF6-C37288608F9B@kernel.crashing.org>
Message-ID: <4A38E135.3030600@RuggedCom.com>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Kumar Gala wrote:
> 
> On Jun 16, 2009, at 3:50 PM, Richard Retanubun wrote:
> 
>> [snip]
>>> How about removing the  include "netdev.h" and adding:
>>>
>>> extern int uec_standard_init(bd_t *bis);
>>>
>> D'oh!
>>
>> diff --git a/cpu/mpc83xx/cpu.c b/cpu/mpc83xx/cpu.c
>> index c4331ae..f29b848 100644
>> --- a/cpu/mpc83xx/cpu.c
>> +++ b/cpu/mpc83xx/cpu.c
>> @@ -33,13 +33,14 @@
>>  #include <asm/processor.h>
>>  #include <libfdt.h>
>>  #include <tsec.h>
>> -#include <netdev.h>
>>  #include <fsl_esdhc.h>
>>  #ifdef CONFIG_BOOTCOUNT_LIMIT
>>  #include <asm/immap_qe.h>
>>  #include <asm/io.h>
>>  #endif
>>
>> +extern int uec_standard_init(bd_t *bis);
>> +
>>  DECLARE_GLOBAL_DATA_PTR;
>>
>>  int checkcpu(void)
>>
>>
>> Yeah, this works (if we want to patch it, better do it for the 
>> cpu/mpc85xx/cpu.c also though) :)
>>
>>> IMHO this submission should be backed out - it looks like it wasn't 
>>> properly baked.
>>
>> I'll let you make the call on that, the patch does introduce a nice 
>> cleanup on a
>> problem I've compounded in the past so I am quite grateful for it.
> 
> This is my bad.. I hope this patch isn't actually in v2009.06.  (it 
> wasn't intended to be).
> 
> - k

Not sure if it is my turn to answer, but this is in v2009.06, as Ben stated before,

http://git.denx.de/?p=u-boot.git;a=commit;h=8e55258f144764de8902e9f078a7ad4c6c022c2f

- R