public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] PATCH: bugfix for nand erase failure with bad blocks
Date: Wed, 17 Jun 2009 17:04:15 -0500	[thread overview]
Message-ID: <4A39685F.6030304@freescale.com> (raw)
In-Reply-To: <4A391724.2080207@valueteam.com>

Michele De Candia (VT) wrote:
>> I'm a little uneasy about changing the normal erase command from size 
>> to end
>> -- it would break existing uses.  Though, it would make it consistent 
>> with
>> the NOR erase command.  Perhaps a period where it warns but accepts 
>> anyway a
>> size, if the second parameter is less than the first.
>>   
> 
> This doesn't work always: for example, when you erase at the NAND begin, 
> second parameter could be greater than first one.

Hmm... perhaps check the alignment?  If "end" is supposed to be the last 
to-be-erased byte, not the first not-to-be-erased byte, then if the low 
bits are 0 it's a size (and gets a warning) and if they're 1 it's an end?

Or just always use the new syntax, announce it loudly, and grep the 
board config files for scripts to update.  Or leave it alone and only 
change the plus variant.  :-)

> It can always warn user when he uses the first erase way.

Then what would be the correct, non-warning-producing way to erase a 
region of flash regardless of its bad block content?

-Scott

  reply	other threads:[~2009-06-17 22:04 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-06-16 13:06 [U-Boot] PATCH: bugfix for nand erase failure with bad blocks Michele De Candia
2009-06-16 18:10 ` Wolfgang Denk
2009-06-16 19:51   ` Michele De Candia
2009-06-16 20:09     ` Wolfgang Denk
2009-06-16 20:19       ` Scott Wood
2009-06-17  7:18         ` Michele De Candia
2009-06-17  7:43           ` Michele De Candia
2009-06-17  7:44           ` Michele De Candia
2009-06-17 15:54             ` Scott Wood
2009-06-17 16:17               ` Michele De Candia
2009-06-17 22:04                 ` Scott Wood [this message]
2009-06-17 22:15                   ` Wolfgang Denk
2009-06-17 22:34                     ` Scott Wood
2009-06-19  7:01                       ` Michele De Candia
2009-06-17 22:11               ` Wolfgang Denk
2009-06-17  9:18         ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A39685F.6030304@freescale.com \
    --to=scottwood@freescale.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox