public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
* [U-Boot] [PATCH] uec: Fix compile warning
@ 2009-06-17 13:22 Kumar Gala
  2009-06-17 13:23 ` Kumar Gala
                   ` (2 more replies)
  0 siblings, 3 replies; 5+ messages in thread
From: Kumar Gala @ 2009-06-17 13:22 UTC (permalink / raw)
  To: u-boot

cpu.c: In function 'cpu_eth_init':
cpu.c:371: warning: implicit declaration of function 'uec_standard_init'

Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
---
 include/netdev.h |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/include/netdev.h b/include/netdev.h
index aed5c4c..92eceb1 100644
--- a/include/netdev.h
+++ b/include/netdev.h
@@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis);
 int eepro100_initialize(bd_t *bis);
 int eth_3com_initialize (bd_t * bis);
 int fec_initialize (bd_t *bis);
+int uec_standard_init(bd_t *bis);
 int greth_initialize(bd_t *bis);
 void gt6426x_eth_initialize(bd_t *bis);
 int inca_switch_initialize(bd_t *bis);
-- 
1.6.0.6

^ permalink raw reply related	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] uec: Fix compile warning
  2009-06-17 13:22 [U-Boot] [PATCH] uec: Fix compile warning Kumar Gala
@ 2009-06-17 13:23 ` Kumar Gala
  2009-06-18  5:14 ` Ben Warren
  2009-07-23  5:55 ` Ben Warren
  2 siblings, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2009-06-17 13:23 UTC (permalink / raw)
  To: u-boot


On Jun 17, 2009, at 8:22 AM, Kumar Gala wrote:

> cpu.c: In function 'cpu_eth_init':
> cpu.c:371: warning: implicit declaration of function  
> 'uec_standard_init'
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
> include/netdev.h |    1 +
> 1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/netdev.h b/include/netdev.h
> index aed5c4c..92eceb1 100644
> --- a/include/netdev.h
> +++ b/include/netdev.h
> @@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis);
> int eepro100_initialize(bd_t *bis);
> int eth_3com_initialize (bd_t * bis);
> int fec_initialize (bd_t *bis);
> +int uec_standard_init(bd_t *bis);
> int greth_initialize(bd_t *bis);
> void gt6426x_eth_initialize(bd_t *bis);
> int inca_switch_initialize(bd_t *bis);
> -- 
> 1.6.0.6

Ben,

This should address the warning that Richard reported.  Feel free to  
pick this up via the net tree.

- k

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] uec: Fix compile warning
  2009-06-17 13:22 [U-Boot] [PATCH] uec: Fix compile warning Kumar Gala
  2009-06-17 13:23 ` Kumar Gala
@ 2009-06-18  5:14 ` Ben Warren
  2009-07-23  5:55 ` Ben Warren
  2 siblings, 0 replies; 5+ messages in thread
From: Ben Warren @ 2009-06-18  5:14 UTC (permalink / raw)
  To: u-boot

Kumar Gala wrote:
> cpu.c: In function 'cpu_eth_init':
> cpu.c:371: warning: implicit declaration of function 'uec_standard_init'
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  include/netdev.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/netdev.h b/include/netdev.h
> index aed5c4c..92eceb1 100644
> --- a/include/netdev.h
> +++ b/include/netdev.h
> @@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis);
>  int eepro100_initialize(bd_t *bis);
>  int eth_3com_initialize (bd_t * bis);
>  int fec_initialize (bd_t *bis);
> +int uec_standard_init(bd_t *bis);
>  int greth_initialize(bd_t *bis);
>  void gt6426x_eth_initialize(bd_t *bis);
>  int inca_switch_initialize(bd_t *bis);
>   
Applied to net repo.

thanks,
Ben

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] uec: Fix compile warning
  2009-06-17 13:22 [U-Boot] [PATCH] uec: Fix compile warning Kumar Gala
  2009-06-17 13:23 ` Kumar Gala
  2009-06-18  5:14 ` Ben Warren
@ 2009-07-23  5:55 ` Ben Warren
  2009-07-23 15:08   ` Kumar Gala
  2 siblings, 1 reply; 5+ messages in thread
From: Ben Warren @ 2009-07-23  5:55 UTC (permalink / raw)
  To: u-boot

Kumar Gala wrote:
> cpu.c: In function 'cpu_eth_init':
> cpu.c:371: warning: implicit declaration of function 'uec_standard_init'
>
> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
> ---
>  include/netdev.h |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/include/netdev.h b/include/netdev.h
> index aed5c4c..92eceb1 100644
> --- a/include/netdev.h
> +++ b/include/netdev.h
> @@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis);
>  int eepro100_initialize(bd_t *bis);
>  int eth_3com_initialize (bd_t * bis);
>  int fec_initialize (bd_t *bis);
> +int uec_standard_init(bd_t *bis);
>  int greth_initialize(bd_t *bis);
>  void gt6426x_eth_initialize(bd_t *bis);
>  int inca_switch_initialize(bd_t *bis);
>   
I'm not sure why I applied this - the prototype is already there and 
this is not sorted alphabetically.

Anyway, reverted and you shouldn't get the warning.

regards,
Ben

^ permalink raw reply	[flat|nested] 5+ messages in thread

* [U-Boot] [PATCH] uec: Fix compile warning
  2009-07-23  5:55 ` Ben Warren
@ 2009-07-23 15:08   ` Kumar Gala
  0 siblings, 0 replies; 5+ messages in thread
From: Kumar Gala @ 2009-07-23 15:08 UTC (permalink / raw)
  To: u-boot


On Jul 23, 2009, at 12:55 AM, Ben Warren wrote:

> Kumar Gala wrote:
>> cpu.c: In function 'cpu_eth_init':
>> cpu.c:371: warning: implicit declaration of function  
>> 'uec_standard_init'
>>
>> Signed-off-by: Kumar Gala <galak@kernel.crashing.org>
>> ---
>> include/netdev.h |    1 +
>> 1 files changed, 1 insertions(+), 0 deletions(-)
>>
>> diff --git a/include/netdev.h b/include/netdev.h
>> index aed5c4c..92eceb1 100644
>> --- a/include/netdev.h
>> +++ b/include/netdev.h
>> @@ -50,6 +50,7 @@ int e1000_initialize(bd_t *bis);
>> int eepro100_initialize(bd_t *bis);
>> int eth_3com_initialize (bd_t * bis);
>> int fec_initialize (bd_t *bis);
>> +int uec_standard_init(bd_t *bis);
>> int greth_initialize(bd_t *bis);
>> void gt6426x_eth_initialize(bd_t *bis);
>> int inca_switch_initialize(bd_t *bis);
>>
> I'm not sure why I applied this - the prototype is already there and  
> this is not sorted alphabetically.
>
> Anyway, reverted and you shouldn't get the warning.

I think part of that was because Wolfgang already applied a similar  
fix himself.

- k

^ permalink raw reply	[flat|nested] 5+ messages in thread

end of thread, other threads:[~2009-07-23 15:08 UTC | newest]

Thread overview: 5+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2009-06-17 13:22 [U-Boot] [PATCH] uec: Fix compile warning Kumar Gala
2009-06-17 13:23 ` Kumar Gala
2009-06-18  5:14 ` Ben Warren
2009-07-23  5:55 ` Ben Warren
2009-07-23 15:08   ` Kumar Gala

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox