[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Mark Jackson]

This patch correctly sets up the guard time parameter in
the Atmel LCDC driver.

This works on the AVR32 platform, but needs to be tested
under the AT91 platform which shares the same code base.

Signed-off-by: Mark Jackson <mpfj@mimc.co.uk>
---
  drivers/video/atmel_lcdfb.c |    5 +++--
  1 files changed, 3 insertions(+), 2 deletions(-)

diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
index 3a51cc7..14f578e 100644
--- a/drivers/video/atmel_lcdfb.c
+++ b/drivers/video/atmel_lcdfb.c
@@ -42,6 +42,7 @@ short console_row;
  /* configurable parameters */
  #define ATMEL_LCDC_CVAL_DEFAULT		0xc8
  #define ATMEL_LCDC_DMA_BURST_LEN	8
+#define ATMEL_LCDC_GUARD_TIME		2

  #if defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91CAP9)
  #define ATMEL_LCDC_FIFO_SIZE		2048
@@ -69,7 +70,7 @@ void lcd_ctrl_init(void *lcdbase)

  	/* Turn off the LCD controller and the DMA controller */
  	lcdc_writel(panel_info.mmio, ATMEL_LCDC_PWRCON,
-		    1 << ATMEL_LCDC_GUARDT_OFFSET);
+		    ATMEL_LCDC_GUARD_TIME << ATMEL_LCDC_GUARDT_OFFSET);

  	/* Wait for the LCDC core to become idle */
  	while (lcdc_readl(panel_info.mmio, ATMEL_LCDC_PWRCON) & ATMEL_LCDC_BUSY)
@@ -150,7 +151,7 @@ void lcd_ctrl_init(void *lcdbase)

  	lcdc_writel(panel_info.mmio, ATMEL_LCDC_DMACON, ATMEL_LCDC_DMAEN);
  	lcdc_writel(panel_info.mmio, ATMEL_LCDC_PWRCON,
-		    (1 << ATMEL_LCDC_GUARDT_OFFSET) | ATMEL_LCDC_PWR);
+		    (ATMEL_LCDC_GUARD_TIME << ATMEL_LCDC_GUARDT_OFFSET) | ATMEL_LCDC_PWR);
  }

  ulong calc_fbsize(void)

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Mark Jackson]

Mark Jackson wrote:
> This patch correctly sets up the guard time parameter in
> the Atmel LCDC driver.
> 
> This works on the AVR32 platform, but needs to be tested
> under the AT91 platform which shares the same code base.
> 
> Signed-off-by: Mark Jackson <mpfj@mimc.co.uk>
> ---
>   drivers/video/atmel_lcdfb.c |    5 +++--
>   1 files changed, 3 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/video/atmel_lcdfb.c b/drivers/video/atmel_lcdfb.c
> index 3a51cc7..14f578e 100644
> --- a/drivers/video/atmel_lcdfb.c
> +++ b/drivers/video/atmel_lcdfb.c
> @@ -42,6 +42,7 @@ short console_row;
>   /* configurable parameters */
>   #define ATMEL_LCDC_CVAL_DEFAULT		0xc8
>   #define ATMEL_LCDC_DMA_BURST_LEN	8
> +#define ATMEL_LCDC_GUARD_TIME		2

This should be ...

 >  #define ATMEL_LCDC_CVAL_DEFAULT		0xc8
 >  #define ATMEL_LCDC_DMA_BURST_LEN	8
 > +#define ATMEL_LCDC_GUARD_TIME		2

... without the extra space at the start.

> 
>   #if defined(CONFIG_AT91SAM9263) || defined(CONFIG_AT91CAP9)
>   #define ATMEL_LCDC_FIFO_SIZE		2048
> @@ -69,7 +70,7 @@ void lcd_ctrl_init(void *lcdbase)
> 
>   	/* Turn off the LCD controller and the DMA controller */
>   	lcdc_writel(panel_info.mmio, ATMEL_LCDC_PWRCON,
> -		    1 << ATMEL_LCDC_GUARDT_OFFSET);
> +		    ATMEL_LCDC_GUARD_TIME << ATMEL_LCDC_GUARDT_OFFSET);
> 
>   	/* Wait for the LCDC core to become idle */
>   	while (lcdc_readl(panel_info.mmio, ATMEL_LCDC_PWRCON) & ATMEL_LCDC_BUSY)
> @@ -150,7 +151,7 @@ void lcd_ctrl_init(void *lcdbase)
> 
>   	lcdc_writel(panel_info.mmio, ATMEL_LCDC_DMACON, ATMEL_LCDC_DMAEN);
>   	lcdc_writel(panel_info.mmio, ATMEL_LCDC_PWRCON,
> -		    (1 << ATMEL_LCDC_GUARDT_OFFSET) | ATMEL_LCDC_PWR);
> +		    (ATMEL_LCDC_GUARD_TIME << ATMEL_LCDC_GUARDT_OFFSET) | ATMEL_LCDC_PWR);
>   }
> 
>   ulong calc_fbsize(void)

My patch has been mangled ... there's an extra space at the start of each 
"unchanged" patch line.

Any ideas ?

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Haavard Skinnemoen]

Mark Jackson wrote:
> User-Agent: Thunderbird 2.0.0.21 (X11/20090409)

(...)

> My patch has been mangled ... there's an extra space at the start of each 
> "unchanged" patch line.

Read about how to make Thunderbird behave here:

http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/email-clients.txt

Haavard

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Mark Jackson]

Haavard Skinnemoen wrote:
> Mark Jackson wrote:
>> User-Agent: Thunderbird 2.0.0.21 (X11/20090409)
> 
> (...)
> 
>> My patch has been mangled ... there's an extra space at the start of each 
>> "unchanged" patch line.
> 
> Read about how to make Thunderbird behave here:
> 
> http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/email-clients.txt

But I've sent in patches before without any problems !!

And as per my other mail on the topic, I posted to both the u-boot at denx and u-boot at avr32linux MLs, and only *one* of the incoming mails (u-boot at denx) was mangled.

Any ideas ?

Regards
Mark

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Peter Tyser]

On Mon, 2009-06-22 at 16:31 +0100, Mark Jackson wrote:
> Haavard Skinnemoen wrote:
> > Mark Jackson wrote:
> >> User-Agent: Thunderbird 2.0.0.21 (X11/20090409)
> > 
> > (...)
> > 
> >> My patch has been mangled ... there's an extra space at the start of each 
> >> "unchanged" patch line.
> > 
> > Read about how to make Thunderbird behave here:
> > 
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/email-clients.txt
> 
> But I've sent in patches before without any problems !!
> 
> And as per my other mail on the topic, I posted to both the u-boot at denx and u-boot at avr32linux MLs, and only *one* of the incoming mails (u-boot at denx) was mangled.
> 
> Any ideas ?

I'm not sure why the 2 mailing lists would behave differently, but using
"git format-patch" and "git send-email" is one way to take the email
client out of the picture.  The git commands are the prefered method to
send patches, especially if you're going to be sending more in the
future.

Best,
Peter

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Haavard Skinnemoen]

On Mon, 22 Jun 2009 16:31:20 +0100
Mark Jackson <mpfj-list@mimc.co.uk> wrote:

> Haavard Skinnemoen wrote:
> > Mark Jackson wrote:
> >> User-Agent: Thunderbird 2.0.0.21 (X11/20090409)
> > 
> > (...)
> > 
> >> My patch has been mangled ... there's an extra space at the start
> >> of each "unchanged" patch line.
> > 
> > Read about how to make Thunderbird behave here:
> > 
> > http://git.kernel.org/?p=linux/kernel/git/torvalds/linux-2.6.git;a=blob;f=Documentation/email-clients.txt
> 
> But I've sent in patches before without any problems !!

Weird.

> And as per my other mail on the topic, I posted to both the
> u-boot at denx and u-boot at avr32linux MLs, and only *one* of the incoming
> mails (u-boot at denx) was mangled.

Hmm...the one I received through avr32linux.org looks mangled too; it
has extra spaces before some of the lines.

> Any ideas ?

My guess is that format=flowed is causing problems. From the patch:

Content-Type: text/plain; charset=ISO-8859-1; format=flowed

I wish people who implement e-mail software weren't completely insane.

Haavard

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Jean-Christophe PLAGNIOL-VILLARD]

On 15:58 Mon 22 Jun     , Mark Jackson wrote:
> This patch correctly sets up the guard time parameter in
> the Atmel LCDC driver.
> 
> This works on the AVR32 platform, but needs to be tested
> under the AT91 platform which shares the same code base.
for at91 the GUARD_TIME is 1 and IIRC it's lcd specific

Best Regards,
J.

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Haavard Skinnemoen]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> for at91 the GUARD_TIME is 1 and IIRC it's lcd specific

You just contradicted yourself.

The Guard time is the number of empty frames (with control signals
enabled but no data) to wait before starting to send valid data to the
display.

Setting it slightly too high shouldn't make any difference. However,
setting it slightly too low may cause strange failures every now and
then.

Haavard

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Jean-Christophe PLAGNIOL-VILLARD]

On 08:53 Tue 23 Jun     , Haavard Skinnemoen wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> > for at91 the GUARD_TIME is 1 and IIRC it's lcd specific
> 
> You just contradicted yourself.
at91 boards
> 
> The Guard time is the number of empty frames (with control signals
> enabled but no data) to wait before starting to send valid data to the
> display.
> 
> Setting it slightly too high shouldn't make any difference. However,
> setting it slightly too low may cause strange failures every now and
> then.
for at91 boards it's 1 and I've never seen any problem, same in the kernel

So I'll prefer to make it optionial and no hardcoded for all boards.

Best Regards,
J.

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Haavard Skinnemoen]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 08:53 Tue 23 Jun     , Haavard Skinnemoen wrote:
> > Jean-Christophe PLAGNIOL-VILLARD wrote:  
> > > for at91 the GUARD_TIME is 1 and IIRC it's lcd specific  
> > 
> > You just contradicted yourself.  
> at91 boards

Ok, I see.

> > 
> > The Guard time is the number of empty frames (with control signals
> > enabled but no data) to wait before starting to send valid data to the
> > display.
> > 
> > Setting it slightly too high shouldn't make any difference. However,
> > setting it slightly too low may cause strange failures every now and
> > then.  
> for at91 boards it's 1 and I've never seen any problem, same in the kernel
> 
> So I'll prefer to make it optionial and no hardcoded for all boards.

Good point. How about if we turn it into a configuration symbol and
default to 1 if it's unset?

Haavard

[U-Boot] [PATCH ... resent] Atmel LCD driver GUARDTIME fix

[Jean-Christophe PLAGNIOL-VILLARD]

On 09:21 Tue 23 Jun     , Haavard Skinnemoen wrote:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
> > On 08:53 Tue 23 Jun     , Haavard Skinnemoen wrote:
> > > Jean-Christophe PLAGNIOL-VILLARD wrote:  
> > > > for at91 the GUARD_TIME is 1 and IIRC it's lcd specific  
> > > 
> > > You just contradicted yourself.  
> > at91 boards
> 
> Ok, I see.
> 
> > > 
> > > The Guard time is the number of empty frames (with control signals
> > > enabled but no data) to wait before starting to send valid data to the
> > > display.
> > > 
> > > Setting it slightly too high shouldn't make any difference. However,
> > > setting it slightly too low may cause strange failures every now and
> > > then.  
> > for at91 boards it's 1 and I've never seen any problem, same in the kernel
> > 
> > So I'll prefer to make it optionial and no hardcoded for all boards.
> 
> Good point. How about if we turn it into a configuration symbol and
> default to 1 if it's unset?
fine for me

Best Regards,
J.