From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dirk Behme Date: Mon, 22 Jun 2009 20:12:11 +0200 Subject: [U-Boot] [PATCH] mtd: Update MTD infrastructure to support 64bit device size In-Reply-To: <200906221455.35960.sr@denx.de> References: <1242050635-7152-1-git-send-email-sr@denx.de> <4A3C74C3.6010308@googlemail.com> <200906221455.35960.sr@denx.de> Message-ID: <4A3FC97B.1050704@googlemail.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Stefan Roese wrote: > Hi Dirk, > > I forgot to address your first issue. Please see below: > > > >>> +#if !defined(CONFIG_SYS_64BIT_VSPRINTF) >>> +#warning Please define CONFIG_SYS_64BIT_VSPRINTF for correct output! >>> +#endif >>> + >> 1. This preprocessor warning is annoying. Why not enable it in all >> configs where needed and then remove this warning here? > > I could have done that, but this would not have been so easy. Especially with > so many new board ports pending in the u-boot-arch/next branches at that time. > And upcoming board ports would probably fallen through the crack as well. So I > decided to do it this way. Is this a long term solution or only waiting for all u-boot-arch/next branches to be merged? For a long term solution this would be annoying. Maybe we can change this after merge window closed? Thanks and best regards Dirk