public inbox for u-boot@lists.denx.de
 help / color / mirror / Atom feed
From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile
Date: Tue, 23 Jun 2009 23:34:52 +0900	[thread overview]
Message-ID: <4A40E80C.1020507@ruby.dti.ne.jp> (raw)
In-Reply-To: <1243107758-4528-1-git-send-email-plagnioj@jcrosoft.com>

Hi Jean, or someone who understands U-Boot's build system well,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> at the first run of make we generate the autoconf.mk and autoconf.mk.dep
> if not already the case and we currently include only to .dep
> 
> in order to use these autogenerated value we need to include it also evenif
> it's include in config.mk but it's done before there generation
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 81a5cd0..7f3776e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -475,6 +475,7 @@ $(obj)include/autoconf.mk: $(obj)include/config.h
>  	mv $@.tmp $@
>  
>  sinclude $(obj)include/autoconf.mk.dep
> +sinclude $(obj)include/autoconf.mk
>  
>  #########################################################################
>  else	# !config.mk

I'm still thinking how to fix this issue.

The problem here is, deferred expansion on PLATFORM_LDFLAGS doesn't work
expectedly.  In this case,

| autoconf.mk
| -----------
| CONFIG_CPU_LITTLE_ENDIAN=y
| 
| mips_config.mk
| --------------
| 
| ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN))
| PLATFORM_CPPFLAGS	+= $(shell $(CC) -dumpmachine |...
| PLATFORM_LDFLAGS	+= -EL
| else
| PLATFORM_CPPFLAGS	+= $(shell $(CC) -dumpmachine |...
| PLATFORM_LDFLAGS	+= -EB
| endif

doesn't work, but simply doing ...

| ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN))
| PLATFORM_CPPFLAGS	+= $(shell $(CC) -dumpmachine |...
| else
| PLATFORM_CPPFLAGS	+= $(shell $(CC) -dumpmachine |...
| endif
|
| PLATFORM_LDFLAGS	+= -EL

does work.

Then, what needs to be fixed finally?  Can't we have PLATFORM_LDFLAGS
conditionally configured?  or is this a U-Boot's build system issue?

  Shinya

  parent reply	other threads:[~2009-06-23 14:34 UTC|newest]

Thread overview: 29+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2009-05-10 20:56 [U-Boot] [PATCH 1/1] mips: unify lds Jean-Christophe PLAGNIOL-VILLARD
2009-05-10 21:34 ` Wolfgang Denk
2009-05-16  3:59   ` Shinya Kuribayashi
2009-05-16  4:02     ` Shinya Kuribayashi
2009-05-22 23:48     ` [U-Boot] *** PROBABLY SPAM *** " Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 11:35     ` [U-Boot] [PATCH 1/2 V2] mips: add endianness support Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 11:35       ` [U-Boot] [PATCH 2/2 V2] mips: unify lds Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 15:45         ` Shinya Kuribayashi
2009-05-23 15:24       ` [U-Boot] [PATCH 1/2 V2] mips: add endianness support Shinya Kuribayashi
2009-05-23 15:19         ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 17:58           ` Shinya Kuribayashi
2009-05-23 19:41             ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 19:42             ` [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 19:42               ` [U-Boot] [PATCH 2/3] mips: add endianness support Jean-Christophe PLAGNIOL-VILLARD
2009-05-23 19:42                 ` [U-Boot] [PATCH 3/3] mips: unify lds Jean-Christophe PLAGNIOL-VILLARD
2009-05-31 22:27                   ` Wolfgang Denk
2009-05-31 22:26                 ` [U-Boot] [PATCH 2/3] mips: add endianness support Wolfgang Denk
2009-05-23 22:28               ` [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile Wolfgang Denk
2009-05-24 15:18                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-05-24 17:13                   ` Wolfgang Denk
2009-06-23 14:34               ` Shinya Kuribayashi [this message]
2009-06-23 15:14                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-23 15:40                   ` Shinya Kuribayashi
2009-06-23 21:26                     ` Jean-Christophe PLAGNIOL-VILLARD
2009-06-23 17:07               ` Mike Frysinger
2009-06-23 17:33                 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-10 22:35                 ` Wolfgang Denk
2009-07-11  3:18                   ` Mike Frysinger
2009-07-17 19:18               ` Wolfgang Denk

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=4A40E80C.1020507@ruby.dti.ne.jp \
    --to=skuribay@ruby.dti.ne.jp \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox