From mboxrd@z Thu Jan  1 00:00:00 1970
From: Shinya Kuribayashi <skuribay@ruby.dti.ne.jp>
Date: Tue, 23 Jun 2009 23:34:52 +0900
Subject: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general
 Makefile
In-Reply-To: <1243107758-4528-1-git-send-email-plagnioj@jcrosoft.com>
References: <4A18393D.7030100@pobox.com>
	<1243107758-4528-1-git-send-email-plagnioj@jcrosoft.com>
Message-ID: <4A40E80C.1020507@ruby.dti.ne.jp>
List-Id: <u-boot.lists.denx.de>
MIME-Version: 1.0
Content-Type: text/plain; charset="us-ascii"
Content-Transfer-Encoding: 7bit
To: u-boot@lists.denx.de

Hi Jean, or someone who understands U-Boot's build system well,

Jean-Christophe PLAGNIOL-VILLARD wrote:
> at the first run of make we generate the autoconf.mk and autoconf.mk.dep
> if not already the case and we currently include only to .dep
> 
> in order to use these autogenerated value we need to include it also evenif
> it's include in config.mk but it's done before there generation
> 
> Signed-off-by: Jean-Christophe PLAGNIOL-VILLARD <plagnioj@jcrosoft.com>
> ---
>  Makefile |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
> 
> diff --git a/Makefile b/Makefile
> index 81a5cd0..7f3776e 100644
> --- a/Makefile
> +++ b/Makefile
> @@ -475,6 +475,7 @@ $(obj)include/autoconf.mk: $(obj)include/config.h
>  	mv $@.tmp $@
>  
>  sinclude $(obj)include/autoconf.mk.dep
> +sinclude $(obj)include/autoconf.mk
>  
>  #########################################################################
>  else	# !config.mk

I'm still thinking how to fix this issue.

The problem here is, deferred expansion on PLATFORM_LDFLAGS doesn't work
expectedly.  In this case,

| autoconf.mk
| -----------
| CONFIG_CPU_LITTLE_ENDIAN=y
| 
| mips_config.mk
| --------------
| 
| ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN))
| PLATFORM_CPPFLAGS	+= $(shell $(CC) -dumpmachine |...
| PLATFORM_LDFLAGS	+= -EL
| else
| PLATFORM_CPPFLAGS	+= $(shell $(CC) -dumpmachine |...
| PLATFORM_LDFLAGS	+= -EB
| endif

doesn't work, but simply doing ...

| ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN))
| PLATFORM_CPPFLAGS	+= $(shell $(CC) -dumpmachine |...
| else
| PLATFORM_CPPFLAGS	+= $(shell $(CC) -dumpmachine |...
| endif
|
| PLATFORM_LDFLAGS	+= -EL

does work.

Then, what needs to be fixed finally?  Can't we have PLATFORM_LDFLAGS
conditionally configured?  or is this a U-Boot's build system issue?

  Shinya