From mboxrd@z Thu Jan 1 00:00:00 1970 From: Shinya Kuribayashi Date: Wed, 24 Jun 2009 00:40:22 +0900 Subject: [U-Boot] [PATCH 1/3] fix: missing autoconfig.mk from general Makefile In-Reply-To: <20090623151458.GJ23512@game.jcrosoft.org> References: <4A18393D.7030100@pobox.com> <1243107758-4528-1-git-send-email-plagnioj@jcrosoft.com> <4A40E80C.1020507@ruby.dti.ne.jp> <20090623151458.GJ23512@game.jcrosoft.org> Message-ID: <4A40F766.4000902@pobox.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Jean-Christophe PLAGNIOL-VILLARD wrote: >> | ifneq (,$(CONFIG_CPU_LITTLE_ENDIAN)) >> | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... >> | else >> | PLATFORM_CPPFLAGS += $(shell $(CC) -dumpmachine |... >> | endif >> | >> | PLATFORM_LDFLAGS += -EL >> >> does work. > ??? > you compile it as big endian to link it as little ??? Ah, above was just a sample only intended for LE build. >> Then, what needs to be fixed finally? Can't we have PLATFORM_LDFLAGS >> conditionally configured? or is this a U-Boot's build system issue? > it a u-boot build system issues > we need to include the autoconf.mk after generate it to use it in the GENERAL > Makefile which is the case here for final link I know that, but $(obj)include/autoconf.mk will be included by $(TOPDIR)/config.mk. Then what a rationale for including it redundantly by $(TOPDIR/Makefile? I assume that Wolfgang is probably requesting the explanation for that. Autoconf.mk is expected to be generated *before* $(TOPDIR)/config.mk is included, right? If so, do you think your patch is a reasonable enough? Or do we need to consider another approach? Shinya - not a GNU make expert :-(