[U-Boot] show_boot_progess @ ppc not working

Andre Schwarz
2008-12-10T09:56:47Z

Heiko Schocher schrieb:
> Hello Andre,
>
> Andre Schwarz wrote:
>
>> All,
>>
>> can someone tell me why the board specific function "void
>> show_boot_progress(int arg)"
>> is no longer called (at least on MPC5200).
>>
>> Of course this line is present in the board config :
>>
>> #define CONFIG_SHOW_BOOT_PROGRESS 1
>>
>>
>> What have I missed ?
>>
>>
>
> Nothing! Good catch. I tried it on a mpc8xx and
> on a mpx82xx based board and it also didnt worked :-(
>
> Can you try the following patch? (This patch solved it
> on my boards ...)
>
> thanks,
> Heiko
>
> [PATCH] all platforms: make show_boot_progress () again working.
>
> Signed-off-by: Heiko Schocher <hs@denx.de>
> ---
> include/common.h | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/include/common.h b/include/common.h
> index 5968036..6583f00 100644
> --- a/include/common.h
> +++ b/include/common.h
> @@ -693,7 +693,7 @@ int pcmcia_init (void);
> /*
> * Board-specific Platform code can reimplement show_boot_progress ()
> if needed
> */
> -void __attribute__((weak)) show_boot_progress (int val);
> +void show_boot_progress (int val);
>
> #ifdef CONFIG_INIT_CRITICAL
> #error CONFIG_INIT_CRITICAL is deprecated!
>
Heiko,

of course this patch makes it work again.
But the question is : Why is this specific weak function not replaced by
the board specific one ?

This gives me some pain when looking at the other weak functions....

In order to be able to compile u-boot I also (still) have to change
<config.h> into "../include/config.h" inside common/env_embedded.c.
Otherwise the config file is not taken into account and complains about
CFG_ENV_SIZE undeclared.

I've discussed this with Wolfgang already a few weeks ago - he blamed my
system configuration.
This issues occur on my gentoo and ubuntu system.
There's nothing special about this systems (out of the box + ELDK-4.2).

How can we solve this without making a guessing game out of it ?

regards,
Andr?

MATRIX VISION GmbH, Talstra?e 16, DE-71570 Oppenweiler - Registergericht: Amtsgericht Stuttgart, HRB 271090
Gesch?ftsf?hrer: Gerhard Thullner, Werner Armingeon, Uwe Furtner