From: Michael Trimarchi <trimarchi@gandalf.sssup.it>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root
Date: Mon, 29 Jun 2009 14:17:52 +0200 [thread overview]
Message-ID: <4A48B0F0.8070903@gandalf.sssup.it> (raw)
In-Reply-To: <1246289178-18711-1-git-send-email-prafulla@marvell.com>
Prafulla Wadaskar wrote:
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
> drivers/usb/host/ehci-hcd.c | 2 +-
> 1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index bbd547b..7a55638 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
> req->requesttype, req->requesttype,
> le16_to_cpu(req->value), le16_to_cpu(req->index));
>
> - typeReq = req->request << 8 | req->requesttype;
> + typeReq = req->request | req->requesttype << 8;
>
Sorry, but I'm not sure in this inversion. Are your sure?
>
> switch (le16_to_cpu(typeReq)) {
>
Maybe this one has no sense...
Michael
> case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
>
next prev parent reply other threads:[~2009-06-29 12:17 UTC|newest]
Thread overview: 23+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-06-29 15:24 [U-Boot] [PATCH 1/6] net: merge bugfix: Marvell Kirkwood gigabit ethernet driver Prafulla Wadaskar
2009-06-29 15:25 ` [U-Boot] [PATCH v3 2/6] nand: Add Marvell Kirkwood NAND driver Prafulla Wadaskar
2009-06-29 15:25 ` [U-Boot] [PATCH 3/6] arm: Kirkwood: arch specific updated for ehci-Kirkwood driver support Prafulla Wadaskar
2009-06-29 15:26 ` [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root Prafulla Wadaskar
2009-06-29 12:17 ` Michael Trimarchi [this message]
2009-06-29 17:29 ` Prafulla Wadaskar
2009-06-29 18:23 ` Michael Trimarchi
2009-07-03 23:46 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-04 13:05 ` Michael Trimarchi
2009-07-07 18:45 ` Remy Bohmer
2009-07-08 6:19 ` Prafulla Wadaskar
2009-07-08 6:44 ` Michael Trimarchi
2009-07-08 14:12 ` Kumar Gala
2009-07-09 6:10 ` Prafulla Wadaskar
2009-07-07 7:28 ` Prafulla Wadaskar
2009-07-04 16:10 ` [U-Boot] [PATCH 3/6] arm: Kirkwood: arch specific updated for ehci-Kirkwood driver support Jean-Christophe PLAGNIOL-VILLARD
2009-07-07 20:27 ` [U-Boot] [PATCH v3 2/6] nand: Add Marvell Kirkwood NAND driver Jean-Christophe PLAGNIOL-VILLARD
2009-07-07 20:33 ` Scott Wood
2009-07-07 21:28 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-08 5:30 ` Prafulla Wadaskar
2009-06-29 21:05 ` [U-Boot] [PATCH 1/6] net: merge bugfix: Marvell Kirkwood gigabit ethernet driver Jean-Christophe PLAGNIOL-VILLARD
2009-06-29 22:54 ` Ben Warren
2009-07-01 20:37 ` Jean-Christophe PLAGNIOL-VILLARD
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A48B0F0.8070903@gandalf.sssup.it \
--to=trimarchi@gandalf.sssup.it \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox