From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 0/6] Poseidon Board Support (Vivek)
Date: Thu, 02 Jul 2009 05:32:32 -0500 [thread overview]
Message-ID: <4A4C8CC0.1030708@windriver.com> (raw)
In-Reply-To: <1349486.263331246528227099.JavaMail.weblogic@epml17>
Do you have a link to the announcement of the board ?
Is it publically available ?
Tom
VIVEK DALAL wrote:
> Hi Tom
>
> On Jul 02, 2009 00:18 (GMT+09:00) Tom.Rix at windriver.com wrote :
>
>
>> A large part of your changes are reorganizing omap24xx support.
>> Have you looked at how it is already done in omapzoom ?
>> git://git.omapzoom.org/repo/uboot.git
>> I believe omapzoom does it better.
>>
>
> --- Thats one way you can do it. Other way is what I did. Rather then adding seperate files(in include/asm-arm/arch-omap24xx/ folder) for omap2430, what have been done in omapzoom/repo/uboot.git i.e omap2420., omap2430.h, clock.h, clock242x.h, clock243x.h etc. Its better to use #define and put the processor specific code in those macros and make the file names generic. Imagine the scenerio, if there would be 5 processors based on arm1136.
>
>
>> These changes are likely going to conflict with my recent i2c patch
>> http://lists.denx.de/pipermail/u-boot/2009-June/055071.html
>>
>
> ---I think you are only modifying i2c.h file in include/asm-arm/arch-omap24xx/ folder. So thats the only conflicting file between your patch and my patch. In that file I have changed only two lines i.e
> -#define I2C_BASE 0x48070000
> -#define I2C_BASE2 0x48072000 /* nothing hooked up on h4 */
> +/* I2C base */
> +#define I2C_BASE (OMAP24XX_L4_IO_BASE + 0x70000)
> +#define I2C_BASE2 (OMAP24XX_L4_IO_BASE + 0x72000)
> This minimal change will not be heavy when re-basing.
>
> Regards
> Vivek Dalal
>
>
>
>
>
>
>
next parent reply other threads:[~2009-07-02 10:32 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <1349486.263331246528227099.JavaMail.weblogic@epml17>
2009-07-02 10:32 ` Tom [this message]
[not found] <mailman.3398.1246448009.8190.u-boot@lists.denx.de>
2009-07-01 15:18 ` [U-Boot] [PATCH 0/6] Poseidon Board Support (Vivek) Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A4C8CC0.1030708@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox