From: Tom <Tom.Rix@windriver.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache
Date: Mon, 06 Jul 2009 21:57:23 -0500 [thread overview]
Message-ID: <4A52B993.1090103@windriver.com> (raw)
In-Reply-To: <13B9B4C6EF24D648824FF11BE8967162039644516B@dlee02.ent.ti.com>
Woodruff, Richard wrote:
>> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On
>> Behalf Of Tom Rix
>> Sent: Monday, July 06, 2009 11:48 AM
>>
>
>
>> Since there is only one version of flushing the dcache for
>> arm_cortex8, rename v7_flush_dcache_all to the the generic
>> name flush_dcache. Because the function is intended for
>> only omap3 boards, move the function to the new file
>> cache_flush.S.
>>
>
> Minor point is file name or function name might change to be more reflective of what it does (cache_ops.S, and invalidate_dcache()). As there is not really any 'flush' (cleaning out dirty entries to main memory).
>
>
I will change the name to cache_ops.S
flush_dcache was chosen to match other boards/cpu's and one of the main
reasons for this change. If Jean is ok changing flush_dcache to
invalidate_dcache, I will make that change too.
Tom
> Today the dcache is not even enabled in ARM ports. To do so requires MMU to be enabled to properly map IO regions as non-cached.
>
> As such all we ever need to do is possibly invalidate icache at run time (say you use Kermit to download something and try to execute it).
>
> The dcache invalidate today is only there to setup cache in clean state before calling the kernel.
>
> Later on a dcache-flush/icache-invalidate might need to be added if Dcache is actually enabled.
>
> Regards,
> Richard W.
>
>
next prev parent reply other threads:[~2009-07-07 2:57 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 16:47 [U-Boot] V2 remove omap3 compiler warning wrt v7_flush_dcache_all Tom Rix
2009-07-06 16:47 ` [U-Boot] [PATCH 1/2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Tom Rix
2009-07-06 16:47 ` [U-Boot] [PATCH 2/2] OMAP3 Fix compiler warning for get_device_type Tom Rix
2009-07-06 17:34 ` [U-Boot] [PATCH 1/2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache Woodruff, Richard
2009-07-07 2:57 ` Tom [this message]
2009-07-07 20:31 ` Jean-Christophe PLAGNIOL-VILLARD
2009-07-07 20:44 ` Tom
2009-07-07 21:20 ` Jean-Christophe PLAGNIOL-VILLARD
2009-08-08 9:47 ` Wolfgang Denk
2009-08-08 13:40 ` Tom
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A52B993.1090103@windriver.com \
--to=tom.rix@windriver.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox