From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tom Date: Mon, 06 Jul 2009 21:57:23 -0500 Subject: [U-Boot] [PATCH 1/2] ARM Cortex8 Rename and move v7_flush_dcache_all to flush_dcache In-Reply-To: <13B9B4C6EF24D648824FF11BE8967162039644516B@dlee02.ent.ti.com> References: <1246898879-6567-1-git-send-email-Tom.Rix@windriver.com> <1246898879-6567-2-git-send-email-Tom.Rix@windriver.com> <13B9B4C6EF24D648824FF11BE8967162039644516B@dlee02.ent.ti.com> Message-ID: <4A52B993.1090103@windriver.com> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: u-boot@lists.denx.de Woodruff, Richard wrote: >> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de] On >> Behalf Of Tom Rix >> Sent: Monday, July 06, 2009 11:48 AM >> > > >> Since there is only one version of flushing the dcache for >> arm_cortex8, rename v7_flush_dcache_all to the the generic >> name flush_dcache. Because the function is intended for >> only omap3 boards, move the function to the new file >> cache_flush.S. >> > > Minor point is file name or function name might change to be more reflective of what it does (cache_ops.S, and invalidate_dcache()). As there is not really any 'flush' (cleaning out dirty entries to main memory). > > I will change the name to cache_ops.S flush_dcache was chosen to match other boards/cpu's and one of the main reasons for this change. If Jean is ok changing flush_dcache to invalidate_dcache, I will make that change too. Tom > Today the dcache is not even enabled in ARM ports. To do so requires MMU to be enabled to properly map IO regions as non-cached. > > As such all we ever need to do is possibly invalidate icache at run time (say you use Kermit to download something and try to execute it). > > The dcache invalidate today is only there to setup cache in clean state before calling the kernel. > > Later on a dcache-flush/icache-invalidate might need to be added if Dcache is actually enabled. > > Regards, > Richard W. > >