[U-Boot] [PATCH 1/6] net: merge bugfix: Marvell Kirkwood gigabit ethernet driver

[U-Boot] [PATCH 1/6] net: merge bugfix: Marvell Kirkwood gigabit ethernet driver

[Prafulla Wadaskar]

This patch looks okay on u-boot-net.git/next branch
but when it was merged to u-boot.git/master the last line is missing

Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
---
 drivers/net/kirkwood_egiga.c |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/drivers/net/kirkwood_egiga.c b/drivers/net/kirkwood_egiga.c
index b43bbf2..3c5db19 100644
--- a/drivers/net/kirkwood_egiga.c
+++ b/drivers/net/kirkwood_egiga.c
@@ -662,3 +662,4 @@ int kirkwood_egiga_initialize(bd_t * bis)
 #endif
 	}
 	return 0;
+}
-- 
1.5.3.3

[U-Boot] [PATCH v3 2/6] nand: Add Marvell Kirkwood NAND driver

[Prafulla Wadaskar]

This patch adds a NAND driver for the Marvell Kirkwood SoC's

Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
---
Change log:
v2: updated as per feedback for v1 (cosmetic change)

v3: missing year added for copy right statement

 drivers/mtd/nand/Makefile        |    1 +
 drivers/mtd/nand/kirkwood_nand.c |   82 ++++++++++++++++++++++++++++++++++++++
 2 files changed, 83 insertions(+), 0 deletions(-)
 create mode 100644 drivers/mtd/nand/kirkwood_nand.c

diff --git a/drivers/mtd/nand/Makefile b/drivers/mtd/nand/Makefile
index 71dd5b9..d4d3948 100644
--- a/drivers/mtd/nand/Makefile
+++ b/drivers/mtd/nand/Makefile
@@ -40,6 +40,7 @@ COBJS-$(CONFIG_DRIVER_NAND_BFIN) += bfin_nand.o
 COBJS-$(CONFIG_NAND_DAVINCI) += davinci_nand.o
 COBJS-$(CONFIG_NAND_FSL_ELBC) += fsl_elbc_nand.o
 COBJS-$(CONFIG_NAND_FSL_UPM) += fsl_upm.o
+COBJS-$(CONFIG_NAND_KIRKWOOD) += kirkwood_nand.o
 COBJS-$(CONFIG_NAND_MPC5121_NFC) += mpc5121_nfc.o
 COBJS-$(CONFIG_NAND_NOMADIK) += nomadik.o
 COBJS-$(CONFIG_NAND_S3C2410) += s3c2410_nand.c
diff --git a/drivers/mtd/nand/kirkwood_nand.c b/drivers/mtd/nand/kirkwood_nand.c
new file mode 100644
index 0000000..376378e
--- /dev/null
+++ b/drivers/mtd/nand/kirkwood_nand.c
@@ -0,0 +1,82 @@
+/*
+ * (C) Copyright 2009
+ * Marvell Semiconductor <www.marvell.com>
+ * Written-by: Prafulla Wadaskar <prafulla@marvell.com>
+ *
+ * See file CREDITS for list of people who contributed to this
+ * project.
+ *
+ * This program is free software; you can redistribute it and/or
+ * modify it under the terms of the GNU General Public License as
+ * published by the Free Software Foundation; either version 2 of
+ * the License, or (at your option) any later version.
+ *
+ * This program is distributed in the hope that it will be useful,
+ * but WITHOUT ANY WARRANTY; without even the implied warranty of
+ * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the
+ * GNU General Public License for more details.
+ *
+ * You should have received a copy of the GNU General Public License
+ * along with this program; if not, write to the Free Software
+ * Foundation, Inc., 59 Temple Place, Suite 330, Boston,
+ * MA 02111-1307 USA
+ */
+
+#include <common.h>
+#include <asm/io.h>
+#include <asm/arch/kirkwood.h>
+#include <nand.h>
+
+/* NAND Flash Soc registers */
+struct kwnandf_registers {
+	u32 rd_params;	/* 0x10418 */
+	u32 wr_param;	/* 0x1041c */
+	u8  pad[0x10470 - 0x1041c - 4];
+	u32 ctrl;	/* 0x10470 */
+};
+
+static struct kwnandf_registers *nf_reg =
+	(struct kwnandf_registers *)KW_NANDF_BASE;
+
+/*
+ * hardware specific access to control-lines/bits
+ */
+#define NAND_ACTCEBOOT_BIT		0x02
+
+static void kw_nand_hwcontrol(struct mtd_info *mtd, int cmd,
+			      unsigned int ctrl)
+{
+	struct nand_chip *nc = mtd->priv;
+	u32 offs;
+
+	if (cmd == NAND_CMD_NONE)
+		return;
+
+	if (ctrl & NAND_CLE)
+		offs = (1 << 0);	/* Commands with A[1:0] == 01 */
+	else if (ctrl & NAND_ALE)
+		offs = (1 << 1);	/* Addresses with A[1:0] == 10 */
+	else
+		return;
+
+	writeb(cmd, nc->IO_ADDR_W + offs);
+}
+
+void kw_nand_select_chip(struct mtd_info *mtd, int chip)
+{
+	u32 data;
+
+	data = readl(&nf_reg->ctrl);
+	data |= NAND_ACTCEBOOT_BIT;
+	writel(data, &nf_reg->ctrl);
+}
+
+int board_nand_init(struct nand_chip *nand)
+{
+	nand->options = NAND_COPYBACK | NAND_CACHEPRG | NAND_NO_PADDING;
+	nand->ecc.mode = NAND_ECC_SOFT;
+	nand->cmd_ctrl = kw_nand_hwcontrol;
+	nand->chip_delay = 30;
+	nand->select_chip = kw_nand_select_chip;
+	return 0;
+}
-- 
1.5.3.3

[U-Boot] [PATCH 3/6] arm: Kirkwood: arch specific updated for ehci-Kirkwood driver support

[Prafulla Wadaskar]

This patch abstracts Kirkwood arch specific changes to support ehci-kirkwood driver

Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
---
 cpu/arm926ejs/kirkwood/cpu.c             |    6 +-----
 include/asm-arm/arch-kirkwood/cpu.h      |    8 ++++++++
 include/asm-arm/arch-kirkwood/kirkwood.h |    1 +
 3 files changed, 10 insertions(+), 5 deletions(-)

diff --git a/cpu/arm926ejs/kirkwood/cpu.c b/cpu/arm926ejs/kirkwood/cpu.c
index 194ba1c..795a739 100644
--- a/cpu/arm926ejs/kirkwood/cpu.c
+++ b/cpu/arm926ejs/kirkwood/cpu.c
@@ -74,7 +74,7 @@ unsigned char get_random_hex(void)
  * 64 KByte granularity (e.g., a value of 0x00FF specifies 256 = 16 MByte).
  * NOTE: A value of 0x0 specifies 64-KByte size.
  */
-static unsigned int kw_winctrl_calcsize(unsigned int sizeval)
+unsigned int kw_winctrl_calcsize(unsigned int sizeval)
 {
 	int i;
 	unsigned int j = 0;
@@ -87,10 +87,6 @@ static unsigned int kw_winctrl_calcsize(unsigned int sizeval)
 	return (0x0000ffff & j);
 }
 
-/* prepares data to be loaded in win_Ctrl register */
-#define KWCPU_WIN_CTRL_DATA(size, target, attr, en) (en | (target << 4) \
-			| (attr << 8) | (kw_winctrl_calcsize(size) << 16))
-
 /*
  * kw_config_adr_windows - Configure address Windows
  *
diff --git a/include/asm-arm/arch-kirkwood/cpu.h b/include/asm-arm/arch-kirkwood/cpu.h
index 36064ae..d1440af 100644
--- a/include/asm-arm/arch-kirkwood/cpu.h
+++ b/include/asm-arm/arch-kirkwood/cpu.h
@@ -29,6 +29,9 @@
 
 #ifndef __ASSEMBLY__
 
+#define KWCPU_WIN_CTRL_DATA(size, target, attr, en) (en | (target << 4) \
+			| (attr << 8) | (kw_winctrl_calcsize(size) << 16))
+
 #define KWGBE_PORT_SERIAL_CONTROL1_REG(_x)	\
 		((_x ? KW_EGIGA0_BASE : KW_EGIGA1_BASE) + 0x44c)
 
@@ -57,6 +60,10 @@ enum kwcpu_target {
 
 enum kwcpu_attrib {
 	KWCPU_ATTR_SASRAM = 0x01,
+	KWCPU_ATTR_DRAM_CS0 = 0x0e,
+	KWCPU_ATTR_DRAM_CS1 = 0x0d,
+	KWCPU_ATTR_DRAM_CS2 = 0x0b,
+	KWCPU_ATTR_DRAM_CS3 = 0x07,
 	KWCPU_ATTR_NANDFLASH = 0x2f,
 	KWCPU_ATTR_SPIFLASH = 0x1e,
 	KWCPU_ATTR_BOOTROM = 0x1d,
@@ -155,5 +162,6 @@ int kw_config_mpp(unsigned int mpp0_7, unsigned int mpp8_15,
 		unsigned int mpp16_23, unsigned int mpp24_31,
 		unsigned int mpp32_39, unsigned int mpp40_47,
 		unsigned int mpp48_55);
+unsigned int kw_winctrl_calcsize(unsigned int sizeval);
 #endif /* __ASSEMBLY__ */
 #endif /* _KWCPU_H */
diff --git a/include/asm-arm/arch-kirkwood/kirkwood.h b/include/asm-arm/arch-kirkwood/kirkwood.h
index d5f25f9..52dafc2 100644
--- a/include/asm-arm/arch-kirkwood/kirkwood.h
+++ b/include/asm-arm/arch-kirkwood/kirkwood.h
@@ -55,6 +55,7 @@
 #define KW_CPU_REG_BASE			(KW_REGISTER(0x20100))
 #define KW_TIMER_BASE			(KW_REGISTER(0x20300))
 #define KW_REG_PCIE_BASE		(KW_REGISTER(0x40000))
+#define KW_USB20_BASE			(KW_REGISTER(0x50000))
 #define KW_EGIGA0_BASE			(KW_REGISTER(0x72000))
 #define KW_EGIGA1_BASE			(KW_REGISTER(0x76000))
 
-- 
1.5.3.3

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Prafulla Wadaskar]

Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
---
 drivers/usb/host/ehci-hcd.c |    2 +-
 1 files changed, 1 insertions(+), 1 deletions(-)

diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
index bbd547b..7a55638 100644
--- a/drivers/usb/host/ehci-hcd.c
+++ b/drivers/usb/host/ehci-hcd.c
@@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
 	      req->requesttype, req->requesttype,
 	      le16_to_cpu(req->value), le16_to_cpu(req->index));
 
-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
 	switch (le16_to_cpu(typeReq)) {
 	case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
-- 
1.5.3.3

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Michael Trimarchi]

Prafulla Wadaskar wrote:
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
>  drivers/usb/host/ehci-hcd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
>
> diff --git a/drivers/usb/host/ehci-hcd.c b/drivers/usb/host/ehci-hcd.c
> index bbd547b..7a55638 100644
> --- a/drivers/usb/host/ehci-hcd.c
> +++ b/drivers/usb/host/ehci-hcd.c
> @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device *dev, unsigned long pipe, void *buffer,
>  	      req->requesttype, req->requesttype,
>  	      le16_to_cpu(req->value), le16_to_cpu(req->index));
>  
> -	typeReq = req->request << 8 | req->requesttype;
> +	typeReq = req->request | req->requesttype << 8;
>   
Sorry, but I'm not sure in this inversion. Are your sure?

>  
>  	switch (le16_to_cpu(typeReq)) {
>   
Maybe this one has no sense...
Michael
>  	case DeviceRequest | USB_REQ_GET_DESCRIPTOR:
>   

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Michael Trimarchi [mailto:trimarchi at gandalf.sssup.it] 
> Sent: Monday, June 29, 2009 5:48 PM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
> Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix 
> driver/usb/host/ehci-hcd.c function ehci_submit_root
> 
> Prafulla Wadaskar wrote:
> > Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> > ---
> >  drivers/usb/host/ehci-hcd.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> >
> > diff --git a/drivers/usb/host/ehci-hcd.c 
> b/drivers/usb/host/ehci-hcd.c 
> > index bbd547b..7a55638 100644
> > --- a/drivers/usb/host/ehci-hcd.c
> > +++ b/drivers/usb/host/ehci-hcd.c
> > @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device 
> *dev, unsigned long pipe, void *buffer,
> >  	      req->requesttype, req->requesttype,
> >  	      le16_to_cpu(req->value), le16_to_cpu(req->index));
> >  
> > -	typeReq = req->request << 8 | req->requesttype;
> > +	typeReq = req->request | req->requesttype << 8;
> >   
> Sorry, but I'm not sure in this inversion. Are your sure?
Hi Michael

I spend enough time debugging USB bring up on Kirkwood assuming this shouldn't be really problem, but it was, with this patch the things are working and logical too.

Regards..
Prafulla . .

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Michael Trimarchi]

Prafulla Wadaskar wrote:
>  
>
>   
>> -----Original Message-----
>> From: Michael Trimarchi [mailto:trimarchi at gandalf.sssup.it] 
>> Sent: Monday, June 29, 2009 5:48 PM
>> To: Prafulla Wadaskar
>> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
>> Ronen Shitrit
>> Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix 
>> driver/usb/host/ehci-hcd.c function ehci_submit_root
>>
>> Prafulla Wadaskar wrote:
>>     
>>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
>>> ---
>>>  drivers/usb/host/ehci-hcd.c |    2 +-
>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>
>>> diff --git a/drivers/usb/host/ehci-hcd.c 
>>>       
>> b/drivers/usb/host/ehci-hcd.c 
>>     
>>> index bbd547b..7a55638 100644
>>> --- a/drivers/usb/host/ehci-hcd.c
>>> +++ b/drivers/usb/host/ehci-hcd.c
>>> @@ -550,7 +550,7 @@ ehci_submit_root(struct usb_device 
>>>       
>> *dev, unsigned long pipe, void *buffer,
>>     
>>>  	      req->requesttype, req->requesttype,
>>>  	      le16_to_cpu(req->value), le16_to_cpu(req->index));
>>>  
>>> -	typeReq = req->request << 8 | req->requesttype;
>>> +	typeReq = req->request | req->requesttype << 8;
>>>   
>>>       
>> Sorry, but I'm not sure in this inversion. Are your sure?
>>     
> Hi Michael
>
> I spend enough time debugging USB bring up on Kirkwood assuming this shouldn't be really problem, but it was, with this patch the things are working and logical too.
>
> Regards..
> Prafulla . .
>   
Yes, I have drinked somenthing today :(. Linux do the same

typeReq  = (cmd->bRequestType << 8) | cmd->bRequest;

Sorry
Michael

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Jean-Christophe PLAGNIOL-VILLARD]

On 20:56 Mon 29 Jun     , Prafulla Wadaskar wrote:
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
>  drivers/usb/host/ehci-hcd.c |    2 +-
>  1 files changed, 1 insertions(+), 1 deletions(-)
> 
Remy could you look the marvell usb patch?

Best Regards,
J.

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Michael Trimarchi]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:56 Mon 29 Jun     , Prafulla Wadaskar wrote:
>   
>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
>> ---
>>  drivers/usb/host/ehci-hcd.c |    2 +-
>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>
>>     
> Remy could you look the marvell usb patch?
>   
I think that this one is correct but not yet tested


> Best Regards,
> J.
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
>
>   

-------------- next part --------------
A non-text attachment was scrubbed...
Name: ehci_fix.patch
Type: text/x-patch
Size: 7064 bytes
Desc: not available
Url : http://lists.denx.de/pipermail/u-boot/attachments/20090704/d20a1a61/attachment.bin 

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Remy Bohmer]

Hello All,

2009/7/4 Michael Trimarchi <trimarchi@gandalf.sssup.it>:
> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>
>> On 20:56 Mon 29 Jun ? ? , Prafulla Wadaskar wrote:
>>
>>>
>>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
>>> ---
>>> ?drivers/usb/host/ehci-hcd.c | ? ?2 +-
>>> ?1 files changed, 1 insertions(+), 1 deletions(-)
>>
>> Remy could you look the marvell usb patch?
>>
> I think that this one is correct but not yet tested

Sorry for not being very responsive these days... it is vacation time... ;-)

This patch of Michael looks good, and I prefer that patch above the
marvell usb patch.
If anybody of you are able of testing it, I can apply it. (I do not
have the proper hardware myself)

Kind Regards,

Remy

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: u-boot-bounces at lists.denx.de 
> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Remy Bohmer
> Sent: Wednesday, July 08, 2009 12:16 AM
> To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; 
> Ronen Shitrit
> Cc: u-boot at lists.denx.de
> Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix 
> driver/usb/host/ehci-hcd.c function ehci_submit_root
> 
> Hello All,
> 
> 2009/7/4 Michael Trimarchi <trimarchi@gandalf.sssup.it>:
> > Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>
> >> On 20:56 Mon 29 Jun ? ? , Prafulla Wadaskar wrote:
> >>
> >>>
> >>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> >>> ---
> >>> ?drivers/usb/host/ehci-hcd.c | ? ?2 +-
> >>> ?1 files changed, 1 insertions(+), 1 deletions(-)
> >>
> >> Remy could you look the marvell usb patch?
> >>
> > I think that this one is correct but not yet tested
> 
> Sorry for not being very responsive these days... it is 
> vacation time... ;-)
> 
> This patch of Michael looks good, and I prefer that patch 
> above the marvell usb patch.
Patch by me ;-D
> If anybody of you are able of testing it, I can apply it. (I 
> do not have the proper hardware myself)

Hi Kumar
I have seen a patch by you to this file
Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html
I hope you have h/w and tested ehci-hcd driver :-)
Can you pls comment on this?
FYI: I have tested it for Sheevaplug Kirkwood hardware
If you get a chance, pls go through my patch, I feel it is logical and even in the kernel too. (ref: line 379: linux/drivers/usb/core/hcd.c)

I wonder why it has not been detected on any other platforms yet!
Any one ...Any comments ??

Regards..
Prafulla . .
 
> 
> Kind Regards,
> 
> Remy
> _______________________________________________
> U-Boot mailing list
> U-Boot at lists.denx.de
> http://lists.denx.de/mailman/listinfo/u-boot
> 

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Michael Trimarchi]

Prafulla Wadaskar wrote:
>  
>
>   
>> -----Original Message-----
>> From: u-boot-bounces at lists.denx.de 
>> [mailto:u-boot-bounces at lists.denx.de] On Behalf Of Remy Bohmer
>> Sent: Wednesday, July 08, 2009 12:16 AM
>> To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; 
>> Ronen Shitrit
>> Cc: u-boot at lists.denx.de
>> Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix 
>> driver/usb/host/ehci-hcd.c function ehci_submit_root
>>
>> Hello All,
>>
>> 2009/7/4 Michael Trimarchi <trimarchi@gandalf.sssup.it>:
>>     
>>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>>       
>>>> On 20:56 Mon 29 Jun     , Prafulla Wadaskar wrote:
>>>>
>>>>         
>>>>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
>>>>> ---
>>>>>  drivers/usb/host/ehci-hcd.c |    2 +-
>>>>>  1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>           
>>>> Remy could you look the marvell usb patch?
>>>>
>>>>         
>>> I think that this one is correct but not yet tested
>>>       
>> Sorry for not being very responsive these days... it is 
>> vacation time... ;-)
>>
>> This patch of Michael looks good, and I prefer that patch 
>> above the marvell usb patch.
>>     
> Patch by me ;-D
>   
>> If anybody of you are able of testing it, I can apply it. (I 
>> do not have the proper hardware myself)
>>     
>
> Hi Kumar
> I have seen a patch by you to this file
> Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html
> I hope you have h/w and tested ehci-hcd driver :-)
> Can you pls comment on this?
> FYI: I have tested it for Sheevaplug Kirkwood hardware
> If you get a chance, pls go through my patch, I feel it is logical and even in the kernel too. (ref: line 379: linux/drivers/usb/core/hcd.c)
>
> I wonder why it has not been detected on any other platforms yet!
> Any one ...Any comments ??
>   
Because there was an error in the switch :( maybe, that I fix in my patch,
but I can't test now because I don't have any hardware.

-	typeReq = req->request << 8 | req->requesttype;
+	typeReq = req->request | req->requesttype << 8;
 
-	switch (le16_to_cpu(typeReq)) {
+	switch (typeReq) {

Michael
> Regards..
> Prafulla . .
>  
>   
>> Kind Regards,
>>
>> Remy
>> _______________________________________________
>> U-Boot mailing list
>> U-Boot at lists.denx.de
>> http://lists.denx.de/mailman/listinfo/u-boot
>>
>>     

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Kumar Gala]

On Jul 8, 2009, at 1:44 AM, Michael Trimarchi wrote:

> Prafulla Wadaskar wrote:
>>
>>
>>> -----Original Message-----
>>> From: u-boot-bounces at lists.denx.de [mailto:u-boot-bounces at lists.denx.de 
>>> ] On Behalf Of Remy Bohmer
>>> Sent: Wednesday, July 08, 2009 12:16 AM
>>> To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen  
>>> Shitrit
>>> Cc: u-boot at lists.denx.de
>>> Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci- 
>>> hcd.c function ehci_submit_root
>>>
>>> Hello All,
>>>
>>> 2009/7/4 Michael Trimarchi <trimarchi@gandalf.sssup.it>:
>>>
>>>> Jean-Christophe PLAGNIOL-VILLARD wrote:
>>>>
>>>>> On 20:56 Mon 29 Jun     , Prafulla Wadaskar wrote:
>>>>>
>>>>>
>>>>>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
>>>>>> ---
>>>>>> drivers/usb/host/ehci-hcd.c |    2 +-
>>>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
>>>>>>
>>>>> Remy could you look the marvell usb patch?
>>>>>
>>>>>
>>>> I think that this one is correct but not yet tested
>>>>
>>> Sorry for not being very responsive these days... it is vacation  
>>> time... ;-)
>>>
>>> This patch of Michael looks good, and I prefer that patch above  
>>> the marvell usb patch.
>>>
>> Patch by me ;-D
>>
>>> If anybody of you are able of testing it, I can apply it. (I do  
>>> not have the proper hardware myself)
>>>
>>
>> Hi Kumar
>> I have seen a patch by you to this file
>> Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html
>> I hope you have h/w and tested ehci-hcd driver :-)
>> Can you pls comment on this?
>> FYI: I have tested it for Sheevaplug Kirkwood hardware
>> If you get a chance, pls go through my patch, I feel it is logical  
>> and even in the kernel too. (ref: line 379: linux/drivers/usb/core/ 
>> hcd.c)
>>
>> I wonder why it has not been detected on any other platforms yet!
>> Any one ...Any comments ??
>>
> Because there was an error in the switch :( maybe, that I fix in my  
> patch,
> but I can't test now because I don't have any hardware.
>
> -	typeReq = req->request << 8 | req->requesttype;
> +	typeReq = req->request | req->requesttype << 8;
> -	switch (le16_to_cpu(typeReq)) {
> +	switch (typeReq) {

I'm quite confused by this.. I was just fixing some warnings from the  
fact that we did some read's but never used the results.  If that code  
has changed (or is going to) than my patch is not needed.  I don't  
think the patch I posted has any side effects beyond getting rid of  
the warnings.

- k

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Kumar Gala [mailto:galak at kernel.crashing.org] 
> Sent: Wednesday, July 08, 2009 7:43 PM
> To: Michael Trimarchi
> Cc: Prafulla Wadaskar; Remy Bohmer; u-boot at lists.denx.de; 
> Ashish Karkare; Prabhanjan Sarnaik; Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix 
> driver/usb/host/ehci-hcd.c function ehci_submit_root
> 
> 
> On Jul 8, 2009, at 1:44 AM, Michael Trimarchi wrote:
> 
> > Prafulla Wadaskar wrote:
> >>
> >>
> >>> -----Original Message-----
> >>> From: u-boot-bounces at lists.denx.de 
> >>> [mailto:u-boot-bounces at lists.denx.de
> >>> ] On Behalf Of Remy Bohmer
> >>> Sent: Wednesday, July 08, 2009 12:16 AM
> >>> To: Michael Trimarchi; Ashish Karkare; Prabhanjan Sarnaik; Ronen 
> >>> Shitrit
> >>> Cc: u-boot at lists.denx.de
> >>> Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix 
> driver/usb/host/ehci- 
> >>> hcd.c function ehci_submit_root
> >>>
> >>> Hello All,
> >>>
> >>> 2009/7/4 Michael Trimarchi <trimarchi@gandalf.sssup.it>:
> >>>
> >>>> Jean-Christophe PLAGNIOL-VILLARD wrote:
> >>>>
> >>>>> On 20:56 Mon 29 Jun     , Prafulla Wadaskar wrote:
> >>>>>
> >>>>>
> >>>>>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> >>>>>> ---
> >>>>>> drivers/usb/host/ehci-hcd.c |    2 +-
> >>>>>> 1 files changed, 1 insertions(+), 1 deletions(-)
> >>>>>>
> >>>>> Remy could you look the marvell usb patch?
> >>>>>
> >>>>>
> >>>> I think that this one is correct but not yet tested
> >>>>
> >>> Sorry for not being very responsive these days... it is vacation 
> >>> time... ;-)
> >>>
> >>> This patch of Michael looks good, and I prefer that patch 
> above the 
> >>> marvell usb patch.
> >>>
> >> Patch by me ;-D
> >>
> >>> If anybody of you are able of testing it, I can apply it. 
> (I do not 
> >>> have the proper hardware myself)

Dear Remy
This patch is last dependency to enable Kirkwood Sheevaplug board support.
And I think, nobody else has tested it.
Please kindly apply it before sending pull request for usb.

Regards..
Prafulla . .

> >>>
> >>
> >> Hi Kumar
> >> I have seen a patch by you to this file
> >> Ref: http://lists.denx.de/pipermail/u-boot/2009-July/055652.html
> >> I hope you have h/w and tested ehci-hcd driver :-) Can you pls 
> >> comment on this?
> >> FYI: I have tested it for Sheevaplug Kirkwood hardware If 
> you get a 
> >> chance, pls go through my patch, I feel it is logical and 
> even in the 
> >> kernel too. (ref: line 379: linux/drivers/usb/core/
> >> hcd.c)
> >>
> >> I wonder why it has not been detected on any other platforms yet!
> >> Any one ...Any comments ??
> >>
> > Because there was an error in the switch :( maybe, that I fix in my 
> > patch, but I can't test now because I don't have any hardware.
> >
> > -	typeReq = req->request << 8 | req->requesttype;
> > +	typeReq = req->request | req->requesttype << 8;
> > -	switch (le16_to_cpu(typeReq)) {
> > +	switch (typeReq) {
> 
> I'm quite confused by this.. I was just fixing some warnings 
> from the fact that we did some read's but never used the 
> results.  If that code has changed (or is going to) than my 
> patch is not needed.  I don't think the patch I posted has 
> any side effects beyond getting rid of the warnings.
> 
> - k
> 
> 

[U-Boot] [PATCH 4/6] usb: bugfix driver/usb/host/ehci-hcd.c function ehci_submit_root

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com] 
> Sent: Saturday, July 04, 2009 5:17 AM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
> Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH 4/6] usb: bugfix 
> driver/usb/host/ehci-hcd.c function ehci_submit_root
> 
> On 20:56 Mon 29 Jun     , Prafulla Wadaskar wrote:
> > Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> > ---
> >  drivers/usb/host/ehci-hcd.c |    2 +-
> >  1 files changed, 1 insertions(+), 1 deletions(-)
> > 
> Remy could you look the marvell usb patch?
Dear Remy
Gentle reminder.
Regards..
Prafulla . .

> 
> Best Regards,
> J.
> 

[U-Boot] [PATCH 3/6] arm: Kirkwood: arch specific updated for ehci-Kirkwood driver support

[Jean-Christophe PLAGNIOL-VILLARD]

On 20:55 Mon 29 Jun     , Prafulla Wadaskar wrote:
> This patch abstracts Kirkwood arch specific changes to support ehci-kirkwood driver
> 
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
>  cpu/arm926ejs/kirkwood/cpu.c             |    6 +-----
>  include/asm-arm/arch-kirkwood/cpu.h      |    8 ++++++++
>  include/asm-arm/arch-kirkwood/kirkwood.h |    1 +
>  3 files changed, 10 insertions(+), 5 deletions(-)
applied to u-boot-arm

Best Regards,
J.

[U-Boot] [PATCH v3 2/6] nand: Add Marvell Kirkwood NAND driver

[Jean-Christophe PLAGNIOL-VILLARD]

On 20:55 Mon 29 Jun     , Prafulla Wadaskar wrote:
> This patch adds a NAND driver for the Marvell Kirkwood SoC's
> 
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
> Change log:
> v2: updated as per feedback for v1 (cosmetic change)
> 
> v3: missing year added for copy right statement
Scott I guess it's ok for you

Best Regards,
J.

[U-Boot] [PATCH v3 2/6] nand: Add Marvell Kirkwood NAND driver

[Scott Wood]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:55 Mon 29 Jun     , Prafulla Wadaskar wrote:
>> This patch adds a NAND driver for the Marvell Kirkwood SoC's
>>
>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
>> ---
>> Change log:
>> v2: updated as per feedback for v1 (cosmetic change)
>>
>> v3: missing year added for copy right statement
> Scott I guess it's ok for you

ACK

-Scott

[U-Boot] [PATCH v3 2/6] nand: Add Marvell Kirkwood NAND driver

[Jean-Christophe PLAGNIOL-VILLARD]

On 20:55 Mon 29 Jun     , Prafulla Wadaskar wrote:
> This patch adds a NAND driver for the Marvell Kirkwood SoC's
> 
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
> Change log:
> v2: updated as per feedback for v1 (cosmetic change)
> 
> v3: missing year added for copy right statement
> 
>  drivers/mtd/nand/Makefile        |    1 +
>  drivers/mtd/nand/kirkwood_nand.c |   82 ++++++++++++++++++++++++++++++++++++++
>  2 files changed, 83 insertions(+), 0 deletions(-)
>  create mode 100644 drivers/mtd/nand/kirkwood_nand.c
applied to u-boot-arm

Best Regards,
J.

[U-Boot] [PATCH v3 2/6] nand: Add Marvell Kirkwood NAND driver

[Prafulla Wadaskar]

 

> -----Original Message-----
> From: Jean-Christophe PLAGNIOL-VILLARD [mailto:plagnioj at jcrosoft.com] 
> Sent: Wednesday, July 08, 2009 2:58 AM
> To: Prafulla Wadaskar
> Cc: u-boot at lists.denx.de; Ashish Karkare; Prabhanjan Sarnaik; 
> Ronen Shitrit
> Subject: Re: [U-Boot] [PATCH v3 2/6] nand: Add Marvell 
> Kirkwood NAND driver
> 
> On 20:55 Mon 29 Jun     , Prafulla Wadaskar wrote:
> > This patch adds a NAND driver for the Marvell Kirkwood SoC's
> > 
> > Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> > ---
> > Change log:
> > v2: updated as per feedback for v1 (cosmetic change)
> > 
> > v3: missing year added for copy right statement
> > 
> >  drivers/mtd/nand/Makefile        |    1 +
> >  drivers/mtd/nand/kirkwood_nand.c |   82 
> ++++++++++++++++++++++++++++++++++++++
> >  2 files changed, 83 insertions(+), 0 deletions(-)  create 
> mode 100644 
> > drivers/mtd/nand/kirkwood_nand.c
> applied to u-boot-arm
Thanks jean :-)

Regards..
Prafulla . .

> 
> Best Regards,
> J.
> 

[U-Boot] [PATCH 1/6] net: merge bugfix: Marvell Kirkwood gigabit ethernet driver

[Jean-Christophe PLAGNIOL-VILLARD]

On 20:54 Mon 29 Jun     , Prafulla Wadaskar wrote:
> This patch looks okay on u-boot-net.git/next branch
> but when it was merged to u-boot.git/master the last line is missing
> 
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
>  drivers/net/kirkwood_egiga.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
Ben is ok If I apply it?

Best Regards,
J.

[U-Boot] [PATCH 1/6] net: merge bugfix: Marvell Kirkwood gigabit ethernet driver

[Ben Warren]

Jean-Christophe PLAGNIOL-VILLARD wrote:
> On 20:54 Mon 29 Jun     , Prafulla Wadaskar wrote:
>   
>> This patch looks okay on u-boot-net.git/next branch
>> but when it was merged to u-boot.git/master the last line is missing
>>
>> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
>> ---
>>  drivers/net/kirkwood_egiga.c |    1 +
>>  1 files changed, 1 insertions(+), 0 deletions(-)
>>     
> Ben is ok If I apply it?
>
> Best Regards,
> J.
>   
OK.

regards,
Ben

[U-Boot] [PATCH 1/6] net: merge bugfix: Marvell Kirkwood gigabit ethernet driver

[Jean-Christophe PLAGNIOL-VILLARD]

On 20:54 Mon 29 Jun     , Prafulla Wadaskar wrote:
> This patch looks okay on u-boot-net.git/next branch
> but when it was merged to u-boot.git/master the last line is missing
> 
> Signed-off-by: Prafulla Wadaskar <prafulla@marvell.com>
> ---
>  drivers/net/kirkwood_egiga.c |    1 +
>  1 files changed, 1 insertions(+), 0 deletions(-)
applied to u-boot-arm

Best Regards,
J.