From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Enable support for 64bit printf on all PPC4xx variants
Date: Wed, 08 Jul 2009 16:11:02 -0500 [thread overview]
Message-ID: <4A550B66.1090506@freescale.com> (raw)
In-Reply-To: <20090708200123.BBAB3832E416@gemini.denx.de>
Wolfgang Denk wrote:
>>> I hope we don't have any more such #defines hidden in other header
>>> files?
>> I vote for completely removing these defines then (or at least
>> CONFIG_SYS_64BIT_VSPRINTF) and by this enabling the 64bit printf format for
>> all boards. I myself have hunted problems disguised by incorrect 64bit
>
> I don't want this because of the memory footprint.
>
> Actually I'm pretty much annoyed we need this at all.
Note that the overhead of 64-bit printf (assuming the 64-bit
divide/remainder functions in libgcc aren't pulled in for anything else)
is 2524 bytes on powerpc (using GCC 4.3.2). That's less than NFS,
which gets turned on by default (as was brought up recently). :-)
What if we were to invert the option (CONFIG_SYS_NO_64BIT_VSPRINTF) so
that it would only be disabled on boards at the intersection of tight
space constraints and a board maintainer who's pretty sure this board
doesn't need it? There could also be some warning from printf() if %ll
is used when not supported, and/or it could still check for %ll and pop
a long long from the varargs but discard the high half.
-Scott
next prev parent reply other threads:[~2009-07-08 21:11 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 9:48 [U-Boot] [PATCH] ppc4xx: Enable support for 64bit printf on all PPC4xx variants Stefan Roese
2009-07-06 11:17 ` Wolfgang Denk
2009-07-06 15:39 ` Stefan Roese
2009-07-08 20:01 ` Wolfgang Denk
2009-07-08 21:11 ` Scott Wood [this message]
2009-07-08 21:24 ` Wolfgang Denk
2009-07-08 21:29 ` Scott Wood
2009-07-08 21:57 ` Wolfgang Denk
2009-07-08 22:27 ` Scott Wood
2009-07-09 4:57 ` Stefan Roese
2009-07-09 7:41 ` Wolfgang Denk
2009-07-08 22:18 ` Jerry Van Baren
2009-07-08 22:27 ` Scott Wood
2009-07-09 5:00 ` Stefan Roese
2009-07-09 12:24 ` Jerry Van Baren
2009-07-09 12:48 ` Stefan Roese
2009-07-09 13:02 ` Jerry Van Baren
2009-07-09 4:54 ` Stefan Roese
2009-07-17 18:44 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A550B66.1090506@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox