From: Scott Wood <scottwood@freescale.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH] ppc4xx: Enable support for 64bit printf on all PPC4xx variants
Date: Wed, 08 Jul 2009 17:27:04 -0500 [thread overview]
Message-ID: <4A551D38.4020600@freescale.com> (raw)
In-Reply-To: <4A551B4E.6010102@gmail.com>
Jerry Van Baren wrote:
> Regardless of the in/out debate, we should print a warning if %ll is
> used but not supported. I would suggest simply printing the "%lld" (or
> whatever the format is) and pop two longs from the varargs. That would
> make it clear something is missing and probably wrong.
Better to pop a long long -- two longs will pop too much if we ever have
a 64-bit u-boot. It would be perverse to not have 64-bit printf in such
a case, but if it has to be manually selected, and only affects long
long so as to not be immediately noticed, it could easily happen.
> I don't like printing half and discarding half: it will be erroneous
> with no warning if the upper half != 0.
Yes, but it'd be less erroneous than what we have now.
> It would also have endian
> complications since the half you want to discard depends on the
> machine's endianness (not insurmountable).
Popping a long long and then casting should take care of that.
-Scott
next prev parent reply other threads:[~2009-07-08 22:27 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2009-07-06 9:48 [U-Boot] [PATCH] ppc4xx: Enable support for 64bit printf on all PPC4xx variants Stefan Roese
2009-07-06 11:17 ` Wolfgang Denk
2009-07-06 15:39 ` Stefan Roese
2009-07-08 20:01 ` Wolfgang Denk
2009-07-08 21:11 ` Scott Wood
2009-07-08 21:24 ` Wolfgang Denk
2009-07-08 21:29 ` Scott Wood
2009-07-08 21:57 ` Wolfgang Denk
2009-07-08 22:27 ` Scott Wood
2009-07-09 4:57 ` Stefan Roese
2009-07-09 7:41 ` Wolfgang Denk
2009-07-08 22:18 ` Jerry Van Baren
2009-07-08 22:27 ` Scott Wood [this message]
2009-07-09 5:00 ` Stefan Roese
2009-07-09 12:24 ` Jerry Van Baren
2009-07-09 12:48 ` Stefan Roese
2009-07-09 13:02 ` Jerry Van Baren
2009-07-09 4:54 ` Stefan Roese
2009-07-17 18:44 ` Wolfgang Denk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=4A551D38.4020600@freescale.com \
--to=scottwood@freescale.com \
--cc=u-boot@lists.denx.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox